Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 114333008: Revert of Add tests to make sure ChromeELF.dll imports are correct: (Closed)

Created:
6 years, 11 months ago by Cait (Slow)
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/109483003/ Reason for revert: Breaking WIN tests on waterfall TBR=robertshield@chromium.org,siggi@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -102 lines) Patch
M chrome/chrome_exe.gypi View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome_elf/chrome_elf.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D chrome_elf/elf_imports_unittest.cc View 1 chunk +0 lines, -95 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cait (Slow)
Created Revert of Add tests to make sure ChromeELF.dll imports are correct:
6 years, 11 months ago (2014-01-06 03:28:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caitkp@chromium.org/114333008/1
6 years, 11 months ago (2014-01-06 03:29:06 UTC) #2
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 03:29:39 UTC) #3
Message was sent while issue was closed.
Change committed as 243055

Powered by Google App Engine
This is Rietveld 408576698