tools/metrics/histograms/histogram_ownership.py - Issue 1143323006: Histograms.xml python script housekeeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histogram_ownership.py

Issue 1143323006: Histograms.xml python script housekeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bad_message

Patch Set: Split off the extensions permission weirdness. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histogram_ownership.py

diff --git a/tools/metrics/histograms/histogram_ownership.py b/tools/metrics/histograms/histogram_ownership.py

index 0d13e6abf1eeb6450306d810bae4354ed098b17a..1ce8e4523b2eb7c5e1ee693255f4d0d2932dfd9d 100755

--- a/tools/metrics/histograms/histogram_ownership.py

+++ b/tools/metrics/histograms/histogram_ownership.py

@@ -9,10 +9,12 @@ histograms.

import xml.etree.ElementTree

+import histograms_path

DUMMY_OWNER = "Please list the metric's owners. Add more owner tags as needed."

def main():

- tree = xml.etree.ElementTree.parse('histograms.xml')

+ tree = xml.etree.ElementTree.parse(histograms_path.GetHistogramsFile())

root = tree.getroot()

assert root.tag == 'histogram-configuration'