tools/metrics/histograms/find_unmapped_histograms.py - Issue 1143323006: Histograms.xml python script housekeeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/find_unmapped_histograms.py

Issue 1143323006: Histograms.xml python script housekeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bad_message

Patch Set: Split off the extensions permission weirdness. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/find_unmapped_histograms.py

diff --git a/tools/metrics/histograms/find_unmapped_histograms.py b/tools/metrics/histograms/find_unmapped_histograms.py

index 31e41b5066fd2a4a4f5ac4b828af44b57dd743c1..44c041ee622034c3efef6a8f0669dfd8ce0995f1 100644

--- a/tools/metrics/histograms/find_unmapped_histograms.py

+++ b/tools/metrics/histograms/find_unmapped_histograms.py

@@ -130,7 +130,7 @@ def readChromiumHistograms():

names that might vary during a single run of the app.

Returns:

- A set cotaining any found literal histogram names.

+ A set containing any found literal histogram names.

"""

logging.info('Scanning Chromium source for histograms...')