Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1143253003: Check whether type parameters are loaded before emitting (Closed)

Created:
5 years, 7 months ago by Leaf
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Check whether type parameters are loaded before emitting. This fixes #190. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/0c7e8a86912c8ee8946ae8b8202ce00b0015b931

Patch Set 1 #

Total comments: 2

Patch Set 2 : Handle typedef case as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
A test/codegen/expect/functions.js View 1 chunk +19 lines, -0 lines 0 comments Download
A test/codegen/expect/functions.txt View 1 chunk +1 line, -0 lines 0 comments Download
A test/codegen/functions.dart View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Leaf
5 years, 7 months ago (2015-05-20 16:27:57 UTC) #2
vsm
lgtm with comment https://codereview.chromium.org/1143253003/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1143253003/diff/1/lib/src/codegen/js_codegen.dart#newcode996 lib/src/codegen/js_codegen.dart:996: if (type is InterfaceType && !type.typeArguments.every(_typeIsLoaded)) ...
5 years, 7 months ago (2015-05-20 16:33:34 UTC) #3
Leaf
https://codereview.chromium.org/1143253003/diff/1/lib/src/codegen/js_codegen.dart File lib/src/codegen/js_codegen.dart (right): https://codereview.chromium.org/1143253003/diff/1/lib/src/codegen/js_codegen.dart#newcode996 lib/src/codegen/js_codegen.dart:996: if (type is InterfaceType && !type.typeArguments.every(_typeIsLoaded)) { On 2015/05/20 ...
5 years, 7 months ago (2015-05-20 16:43:24 UTC) #4
vsm
lgtm
5 years, 7 months ago (2015-05-20 16:46:08 UTC) #5
Leaf
5 years, 7 months ago (2015-05-20 16:47:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0c7e8a86912c8ee8946ae8b8202ce00b0015b931 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698