Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1143253003: Check whether type parameters are loaded before emitting (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Handle typedef case as well Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/codegen/expect/functions.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 2a85f77cae73b54bea1a75ceb03ebe27cbfcd755..9c06502914ee71446804b5a43349068c013a1c57 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -993,6 +993,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
type.normalParameterTypes.every(_typeIsLoaded));
}
if (type.isDynamic || type.isVoid || type.isBottom) return true;
+ if (type is ParameterizedType && !type.typeArguments.every(_typeIsLoaded)) {
+ return false;
+ }
return _loader.isLoaded(type.element);
}
« no previous file with comments | « no previous file | test/codegen/expect/functions.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698