Extract some logic from transport_dib into shared_memory.

Extract some logic from transport_dib into shared_memory.

This CL contains no intended behavior change.

Some of the logic in transport_dib_posix.cc made assumptions about the internal
structure of SharedMemoryHandle. I've moved that logic into
shared_memory_posix.cc.

BUG=466437
Committed: https://crrev.com/38aef4f4010fda1317ea1baa3ec25be8f6b4d6eb
Cr-Commit-Position: refs/heads/master@{#332246}

[erikchen, 2015-05-30 00:00:35]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2015-05-30 00:00:35]

thakis: Please review.

https://codereview.chromium.org/1143243007/diff/20001/base/memory/shared_memo...
File base/memory/shared_memory.h (right):

https://codereview.chromium.org/1143243007/diff/20001/base/memory/shared_memo...
base/memory/shared_memory.h:133: #if defined(OS_POSIX) && !defined(OS_ANDROID)
I find longer preprocessor conditionals easier to read than nested preprocessor
conditionals.

[Nico, 2015-05-30 00:02:44]

lgtm!

https://codereview.chromium.org/1143243007/diff/20001/ui/surface/transport_di...
File ui/surface/transport_dib_posix.cc (right):

https://codereview.chromium.org/1143243007/diff/20001/ui/surface/transport_di...
ui/surface/transport_dib_posix.cc:87: if (size == -1 ||
(!shared_memory_.Map(size)))
nit: no parens around (!...) on the rhs (yes, they were there before, but they
didn't belong there before either)

[erikchen, 2015-05-30 00:10:50]

https://codereview.chromium.org/1143243007/diff/20001/ui/surface/transport_di...
File ui/surface/transport_dib_posix.cc (right):

https://codereview.chromium.org/1143243007/diff/20001/ui/surface/transport_di...
ui/surface/transport_dib_posix.cc:87: if (size == -1 ||
(!shared_memory_.Map(size)))
On 2015/05/30 00:02:43, Nico wrote:
> nit: no parens around (!...) on the rhs (yes, they were there before, but they
> didn't belong there before either)

Done. The new version is indeed easier to read.

[erikchen, 2015-05-30 00:13:54]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-05-30 00:13:55]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1143243007/#ps40001
(title: "Comments from thakis.")

[erikchen, 2015-05-30 00:14:14]

The CQ bit was unchecked by erikchen@chromium.org

[erikchen, 2015-05-30 10:04:53]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-05-30 10:05:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143243007/40001

[commit-bot: I haz the power, 2015-05-30 11:29:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-30 11:29:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2015-06-01 17:08:27]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-06-01 17:08:27]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/1143243007/#ps60001
(title: "Fix inverted conditional.")

[commit-bot: I haz the power, 2015-06-01 17:09:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143243007/60001

[commit-bot: I haz the power, 2015-06-01 19:43:47]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-01 19:44:44]

Patchset 4 (id:??) landed as
https://crrev.com/38aef4f4010fda1317ea1baa3ec25be8f6b4d6eb
Cr-Commit-Position: refs/heads/master@{#332246}