Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1143223007: media: Reland "Simplify {Audio|Video}Decoder initialization callback." (Closed)

Created:
5 years, 6 months ago by xhwang
Modified:
5 years, 6 months ago
Reviewers:
watk, bbudge, DaleCurtis, miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, avayvod+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, jasonroberts+watch_google.com, mkwst+moarreviews-renderer_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Reland "Simplify {Audio|Video}Decoder initialization callback." This reverts commit e51969862119f6a721ec5299e41f01cd3df5fd4a with fixes in media/cast/sender/h264_vt_encoder_unittest.cc TBR=dalecurtis@chromium.org,watk@chromium.org,bbudge@chromium.org BUG=126070, 332204 TEST=Updated unittests. Committed: https://crrev.com/59c321f25857b9bc81cb57670854ff9783a44970 Cr-Commit-Position: refs/heads/master@{#333178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -212 lines) Patch
M content/renderer/pepper/video_decoder_shim.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M media/base/audio_decoder.h View 2 chunks +7 lines, -4 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +6 lines, -5 lines 0 comments Download
M media/base/test_helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/test_helpers.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M media/base/video_decoder.h View 3 chunks +8 lines, -5 lines 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/filters/audio_decoder_selector_unittest.cc View 7 chunks +9 lines, -18 lines 0 comments Download
M media/filters/audio_decoder_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M media/filters/decoder_selector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/decoder_selector.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M media/filters/decoder_stream.h View 3 chunks +4 lines, -2 lines 0 comments Download
M media/filters/decoder_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decoder_stream_traits.h View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decoder_stream_traits.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/decrypting_audio_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/filters/decrypting_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/decrypting_video_decoder.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M media/filters/decrypting_video_decoder_unittest.cc View 8 chunks +13 lines, -18 lines 0 comments Download
M media/filters/fake_video_decoder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/fake_video_decoder_unittest.cc View 4 chunks +7 lines, -9 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_video_decoder_unittest.cc View 11 chunks +14 lines, -16 lines 0 comments Download
M media/filters/gpu_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M media/filters/opus_audio_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/opus_audio_decoder.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/video_decoder_selector_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M media/filters/vpx_video_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
xhwang
miu: Please OWNERS review media/cast/sender/h264_vt_encoder_unittest.cc
5 years, 6 months ago (2015-06-05 22:25:25 UTC) #2
miu
On 2015/06/05 22:25:25, xhwang wrote: > miu: Please OWNERS review media/cast/sender/h264_vt_encoder_unittest.cc media/cast/sender/h264_vt_encoder_unittest.cc lgtm
5 years, 6 months ago (2015-06-05 22:28:58 UTC) #3
bbudge
content/renderer/pepper LGTM
5 years, 6 months ago (2015-06-05 22:40:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143223007/1
5 years, 6 months ago (2015-06-05 22:49:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 23:47:02 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 23:47:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/59c321f25857b9bc81cb57670854ff9783a44970
Cr-Commit-Position: refs/heads/master@{#333178}

Powered by Google App Engine
This is Rietveld 408576698