Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: media/cast/sender/h264_vt_encoder_unittest.cc

Issue 1143223007: media: Reland "Simplify {Audio|Video}Decoder initialization callback." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_decoder.h ('k') | media/filters/audio_decoder_selector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/sender/h264_vt_encoder_unittest.cc
diff --git a/media/cast/sender/h264_vt_encoder_unittest.cc b/media/cast/sender/h264_vt_encoder_unittest.cc
index d9790a8f0d4fe4199a2b55ed9ed8695f3a9e1962..89e7c54c0b4725de7d06b48d866f1d35735133c0 100644
--- a/media/cast/sender/h264_vt_encoder_unittest.cc
+++ b/media/cast/sender/h264_vt_encoder_unittest.cc
@@ -65,8 +65,8 @@ namespace cast {
// See comment in end2end_unittest.cc for details on this value.
const double kVideoAcceptedPSNR = 38.0;
-void SavePipelineStatus(PipelineStatus* out_status, PipelineStatus in_status) {
- *out_status = in_status;
+void SaveDecoderInitResult(bool* out_result, bool in_result) {
+ *out_result = in_result;
}
void SaveOperationalStatus(OperationalStatus* out_status,
@@ -132,13 +132,13 @@ class EndToEndFrameChecker
explicit EndToEndFrameChecker(const VideoDecoderConfig& config)
: decoder_(base::MessageLoop::current()->task_runner()),
count_frames_checked_(0) {
- PipelineStatus pipeline_status;
+ bool decoder_init_result;
decoder_.Initialize(
- config, false, base::Bind(&SavePipelineStatus, &pipeline_status),
+ config, false, base::Bind(&SaveDecoderInitResult, &decoder_init_result),
base::Bind(&EndToEndFrameChecker::CompareFrameWithExpected,
base::Unretained(this)));
base::MessageLoop::current()->RunUntilIdle();
- EXPECT_EQ(PIPELINE_OK, pipeline_status);
+ EXPECT_TRUE(decoder_init_result);
}
void PushExpectation(const scoped_refptr<VideoFrame>& frame) {
« no previous file with comments | « media/base/video_decoder.h ('k') | media/filters/audio_decoder_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698