Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1143223005: Report apptest_runner device not found infra failures. (Closed)

Created:
5 years, 6 months ago by msw
Modified:
5 years, 6 months ago
Reviewers:
jbudorick, sky
CC:
jbudorick, Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), jbudorick+watch_chromium.org, klundberg+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yfriedman+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report apptest_runner device not found infra failures. Make AndroidShell.InitShell return an exit code. (infra exit code for infra errors and 'device not found') Inline CleanShell in InitShell; store --origin internally. Move gdb port forwarding to StartShell; minor refactoring. BUG=493900 TEST=Mojo/Mandoline python scripts work as expected. Bots yield purple builds on "device not found" errors. R=sky@chromium.org Committed: https://crrev.com/ecce673617583e7f020518791b97dca6eeccef9e Cr-Commit-Position: refs/heads/master@{#333186}

Patch Set 1 #

Patch Set 2 : Refactoring... #

Patch Set 3 : Simplify changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -54 lines) Patch
M build/android/test_runner.py View 1 chunk +1 line, -2 lines 0 comments Download
M mandoline/tools/android_run_mandoline.py View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/tools/android_mojo_shell.py View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M mojo/tools/apptest_runner.py View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/tools/mopy/android.py View 1 2 7 chunks +42 lines, -42 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 6 months ago (2015-06-05 23:11:00 UTC) #4
sky
LGTM
5 years, 6 months ago (2015-06-05 23:26:41 UTC) #5
jbudorick
build/android/ lgtm
5 years, 6 months ago (2015-06-05 23:27:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143223005/80001
5 years, 6 months ago (2015-06-05 23:29:42 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 6 months ago (2015-06-06 00:31:42 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-06 00:32:41 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ecce673617583e7f020518791b97dca6eeccef9e
Cr-Commit-Position: refs/heads/master@{#333186}

Powered by Google App Engine
This is Rietveld 408576698