Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: mojo/tools/apptest_runner.py

Issue 1143223005: Report apptest_runner device not found infra failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify changes. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/tools/android_mojo_shell.py ('k') | mojo/tools/mopy/android.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/apptest_runner.py
diff --git a/mojo/tools/apptest_runner.py b/mojo/tools/apptest_runner.py
index 02597685646a42f6a84a79380c074ea12a137a48..d33fbea8a19029e5d42d9937b8f84db9b9d891fe 100755
--- a/mojo/tools/apptest_runner.py
+++ b/mojo/tools/apptest_runner.py
@@ -8,6 +8,7 @@
import argparse
import json
import logging
+import os
import sys
import time
@@ -39,11 +40,12 @@ def main():
logger.debug("Test list: %s" % test_list)
shell = None
- extra_args = []
if config.target_os == Config.OS_ANDROID:
from mopy.android import AndroidShell
shell = AndroidShell(config)
- extra_args.extend(shell.PrepareShellRun('localhost'))
+ result = shell.InitShell()
+ if result != 0:
+ return result
tests = []
passed = []
@@ -52,7 +54,7 @@ def main():
test = test_dict["test"]
test_name = test_dict.get("name", test)
test_type = test_dict.get("type", "gtest")
- test_args = test_dict.get("args", []) + extra_args
+ test_args = test_dict.get("args", [])
print "Running %s...%s" % (test_name, ("\n" if args.verbose else "")),
sys.stdout.flush()
« no previous file with comments | « mojo/tools/android_mojo_shell.py ('k') | mojo/tools/mopy/android.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698