Issue 1143223004: Exclude non-optimizable functions from OptimizeFunctionOnNextCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1143223004: Exclude non-optimizable functions from OptimizeFunctionOnNextCall. (Closed)

Created:
5 years, 7 months ago by Jarin

Modified:
5 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev, titzer

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Exclude non-optimizable functions from OptimizeFunctionOnNextCall. BUG=chromium:491481 R=mstarzinger@chromium.org LOG=n Committed: https://crrev.com/a893a5e59a04c700c011f4cd28f070043a5d33d6 Cr-Commit-Position: refs/heads/master@{#28614}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
	M	src/runtime/runtime-test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-491481.js	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download

Total messages: 6 (1 generated)

Jarin

This fix fully expands the removed JSFunction::IsOptimizable from https://codereview.chromium.org/1146423002. I am not sure whether this ...

5 years, 7 months ago (2015-05-24 09:54:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143223004/20001

5 years, 7 months ago (2015-05-26 08:15:50 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-26 08:47:16 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/a893a5e59a04c700c011f4cd28f070043a5d33d6
Cr-Commit-Position: refs/heads/master@{#28614}