Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1146423002: Remove obsolete JSFunction::IsOptimizable predicate. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete JSFunction::IsOptimizable predicate. This just delegates to SharedFunctionInfo::optimization_disabled and was primarily used for assertions. Removing it due to misleading name because already optimized functions reported being "non-optimizable". This relands commit 181d7b85977eb752b19e1de902093783e31330ef. R=titzer@chromium.org Committed: https://crrev.com/eb055cb3c4a75199ad5f0a0e385c8ab817a9ff88 Cr-Commit-Position: refs/heads/master@{#28577}

Patch Set 1 #

Patch Set 2 : Fix assertion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/runtime-profiler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Patch Set #1: Just pure reland. Patch Set #2: Fixed assertion.
5 years, 7 months ago (2015-05-21 16:30:53 UTC) #1
titzer
On 2015/05/21 16:30:53, Michael Starzinger wrote: > Patch Set #1: Just pure reland. > Patch ...
5 years, 7 months ago (2015-05-21 16:33:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1146423002/20001
5 years, 7 months ago (2015-05-22 09:54:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 10:05:23 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 10:05:35 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb055cb3c4a75199ad5f0a0e385c8ab817a9ff88
Cr-Commit-Position: refs/heads/master@{#28577}

Powered by Google App Engine
This is Rietveld 408576698