Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1143153004: Remove Execution::CharAt (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove Execution::CharAt BUG= Committed: https://crrev.com/abaec424f5c93e7392f4a759b90313c41414d692 Cr-Commit-Position: refs/heads/master@{#28758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M src/execution.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-26 12:42:08 UTC) #2
Igor Sheludko
lgtm
5 years, 7 months ago (2015-05-26 17:29:18 UTC) #3
Igor Sheludko
lgtm lgtm
5 years, 7 months ago (2015-05-26 17:29:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143153004/1
5 years, 6 months ago (2015-06-02 10:47:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 11:24:57 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:25:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abaec424f5c93e7392f4a759b90313c41414d692
Cr-Commit-Position: refs/heads/master@{#28758}

Powered by Google App Engine
This is Rietveld 408576698