src/execution.h - Issue 1143153004: Remove Execution::CharAt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/execution.h

Issue 1143153004: Remove Execution::CharAt (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/execution.h

diff --git a/src/execution.h b/src/execution.h

index 643d84f085a450f68e1db6fcddd64f65b0a288f4..fd7636db96103d451ebdc999c3f0939569f07392 100644

--- a/src/execution.h

+++ b/src/execution.h

@@ -94,9 +94,6 @@ class Execution final : public AllStatic {

MUST_USE_RESULT static MaybeHandle<JSRegExp> NewJSRegExp(

Handle<String> pattern, Handle<String> flags);

- // Used to implement [] notation on strings (calls JS code)

- static Handle<Object> CharAt(Handle<String> str, uint32_t index);

static Handle<Object> GetFunctionFor();

static Handle<String> GetStackTraceLine(Handle<Object> recv,

Handle<JSFunction> fun,

« no previous file with comments | « no previous file | src/execution.cc » ('j') | no next file with comments »