Initialize "weakness_type" field in global handles

Initialize "weakness_type" field in global handles

BUG=4122
R=vogelheim@chromium.org
LOG=n

Committed: https://crrev.com/ba0b7f060acd266f269196b7df1bd309b7853270
Cr-Commit-Position: refs/heads/master@{#28504}

[vogelheim, 2015-05-20 09:19:59]

lgtm

lgtm


I take it this fixes an incompletely initialized object, and the reason the
compiler didn't catch is that we're manually handling initialization so we can
efficiently place Node objects in a NodeBlock. Maybe this would be a good case
for "placement new", so that the compiler could still handle  initialization via
constructors?

[jochen (gone - plz use gerrit), 2015-05-20 09:22:42]

On 2015/05/20 at 09:19:59, vogelheim wrote:
> lgtm
> 
> lgtm
> 
> 
> I take it this fixes an incompletely initialized object, and the reason the
compiler didn't catch is that we're manually handling initialization so we can
efficiently place Node objects in a NodeBlock. Maybe this would be a good case
for "placement new", so that the compiler could still handle  initialization via
constructors?

compilers in general don't catch partial initialization of class...
http://lists.cs.uiuc.edu/pipermail/cfe-dev/2015-March/041909.html

[jochen (gone - plz use gerrit), 2015-05-20 09:22:50]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2015-05-20 09:22:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1143143002/1

[commit-bot: I haz the power, 2015-05-20 09:48:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-20 09:48:13]

Patchset 1 (id:??) landed as
https://crrev.com/ba0b7f060acd266f269196b7df1bd309b7853270
Cr-Commit-Position: refs/heads/master@{#28504}