Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Side by Side Diff: src/global-handles.cc

Issue 1143143002: Initialize "weakness_type" field in global handles (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/global-handles.h" 8 #include "src/global-handles.h"
9 9
10 #include "src/vm-state-inl.h" 10 #include "src/vm-state-inl.h"
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 set_in_new_space_list(false); 69 set_in_new_space_list(false);
70 parameter_or_next_free_.next_free = NULL; 70 parameter_or_next_free_.next_free = NULL;
71 weak_callback_ = NULL; 71 weak_callback_ = NULL;
72 } 72 }
73 #endif 73 #endif
74 74
75 void Initialize(int index, Node** first_free) { 75 void Initialize(int index, Node** first_free) {
76 index_ = static_cast<uint8_t>(index); 76 index_ = static_cast<uint8_t>(index);
77 DCHECK(static_cast<int>(index_) == index); 77 DCHECK(static_cast<int>(index_) == index);
78 set_state(FREE); 78 set_state(FREE);
79 set_weakness_type(NORMAL_WEAK);
79 set_in_new_space_list(false); 80 set_in_new_space_list(false);
80 parameter_or_next_free_.next_free = *first_free; 81 parameter_or_next_free_.next_free = *first_free;
81 *first_free = this; 82 *first_free = this;
82 } 83 }
83 84
84 void Acquire(Object* object) { 85 void Acquire(Object* object) {
85 DCHECK(state() == FREE); 86 DCHECK(state() == FREE);
86 object_ = object; 87 object_ = object;
87 class_id_ = v8::HeapProfiler::kPersistentHandleNoClassId; 88 class_id_ = v8::HeapProfiler::kPersistentHandleNoClassId;
88 set_independent(false); 89 set_independent(false);
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1224 DCHECK_EQ(isolate->heap()->the_hole_value(), blocks_[block][offset]); 1225 DCHECK_EQ(isolate->heap()->the_hole_value(), blocks_[block][offset]);
1225 blocks_[block][offset] = object; 1226 blocks_[block][offset] = object;
1226 if (isolate->heap()->InNewSpace(object)) { 1227 if (isolate->heap()->InNewSpace(object)) {
1227 new_space_indices_.Add(size_); 1228 new_space_indices_.Add(size_);
1228 } 1229 }
1229 *index = size_++; 1230 *index = size_++;
1230 } 1231 }
1231 1232
1232 1233
1233 } } // namespace v8::internal 1234 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698