Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1143083006: Revert of Fix dst bound reported by SkTileImageFilter (Closed)

Created:
5 years, 6 months ago by robertphillips
Modified:
5 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix dst bound reported by SkTileImageFilter (patchset #3 id:40001 of https://codereview.chromium.org/1152553006/) Reason for revert: breaking tests Original issue's description: > Fix dst bound reported by SkTileImageFilter > > In the example from the bug we had the filter DAG: > > color filter (table) > 0: xfermode filter (arith) > 0: tile filter [0,80,34,114] -> [0,80,800,480] > 0: color filter (table) > 0: bitmap src 34x34 -> [0,80,34,114] > 1: color filter (table) > 0: picture filter [0, 80, 800, 480] > > computeFastBounds was coming out of the DAG with a bound of [0,80,34,114] which didn't represent the pixels that would be drawn. > > This CL updates SkTileImageFilter to correctly set the bound for the pixels it will hit. > > BUG=493783 > > Committed: https://skia.googlesource.com/skia/+/05be93bbdf09576f7903130e3b106b0a8c7c4b4e TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=493783 Committed: https://skia.googlesource.com/skia/+/a66cc7e1e01bab8590fdcfafb269e21bfe8782fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -136 lines) Patch
D gm/bigtileimagefilter.cpp View 1 chunk +0 lines, -76 lines 0 comments Download
M gm/tileimagefilter.cpp View 2 chunks +28 lines, -30 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 1 chunk +4 lines, -5 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Fix dst bound reported by SkTileImageFilter
5 years, 6 months ago (2015-06-02 17:56:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143083006/1
5 years, 6 months ago (2015-06-02 17:57:15 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 17:57:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a66cc7e1e01bab8590fdcfafb269e21bfe8782fa

Powered by Google App Engine
This is Rietveld 408576698