Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: gm/tileimagefilter.cpp

Issue 1143083006: Revert of Fix dst bound reported by SkTileImageFilter (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/bigtileimagefilter.cpp ('k') | include/effects/SkTileImageFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/tileimagefilter.cpp
diff --git a/gm/tileimagefilter.cpp b/gm/tileimagefilter.cpp
index 82393087b04b68349477f5700fe0832630524716..2c4f6b2b2c80023128c456a1ea47ca69acc9740d 100644
--- a/gm/tileimagefilter.cpp
+++ b/gm/tileimagefilter.cpp
@@ -16,48 +16,46 @@
#define HEIGHT 100
#define MARGIN 12
-static SkBitmap make_bitmap() {
- SkBitmap bitmap;
- bitmap.allocN32Pixels(50, 50);
- SkCanvas canvas(bitmap);
- canvas.clear(0xFF000000);
- SkPaint paint;
- paint.setAntiAlias(true);
- sk_tool_utils::set_portable_typeface(&paint);
- paint.setColor(0xD000D000);
- paint.setTextSize(SkIntToScalar(50));
- const char* str = "e";
- canvas.drawText(str, strlen(str), SkIntToScalar(10), SkIntToScalar(45), paint);
- return bitmap;
-}
-
-
namespace skiagm {
class TileImageFilterGM : public GM {
public:
- TileImageFilterGM() {
+ TileImageFilterGM() : fInitialized(false) {
this->setBGColor(0xFF000000);
}
protected:
- SkString onShortName() override {
+ virtual SkString onShortName() {
return SkString("tileimagefilter");
}
- SkISize onISize() override{
+ void make_bitmap() {
+ fBitmap.allocN32Pixels(50, 50);
+ SkCanvas canvas(fBitmap);
+ canvas.clear(0xFF000000);
+ SkPaint paint;
+ paint.setAntiAlias(true);
+ sk_tool_utils::set_portable_typeface(&paint);
+ paint.setColor(0xD000D000);
+ paint.setTextSize(SkIntToScalar(50));
+ const char* str = "e";
+ canvas.drawText(str, strlen(str), SkIntToScalar(10), SkIntToScalar(45), paint);
+ }
+
+ virtual SkISize onISize() {
return SkISize::Make(WIDTH, HEIGHT);
}
- void onOnceBeforeDraw() override {
- fBitmap = make_bitmap();
+ virtual void onDraw(SkCanvas* canvas) {
+ if (!fInitialized) {
+ make_bitmap();
- fCheckerboard.allocN32Pixels(80, 80);
- SkCanvas checkerboardCanvas(fCheckerboard);
- sk_tool_utils::draw_checkerboard(&checkerboardCanvas, 0xFFA0A0A0, 0xFF404040, 8);
- }
+ fCheckerboard.allocN32Pixels(80, 80);
+ SkCanvas checkerboardCanvas(fCheckerboard);
+ sk_tool_utils::draw_checkerboard(&checkerboardCanvas, 0xFFA0A0A0, 0xFF404040, 8);
- void onDraw(SkCanvas* canvas) override {
+ fInitialized = true;
+ }
canvas->clear(SK_ColorBLACK);
int x = 0, y = 0;
@@ -111,14 +109,14 @@
canvas->restore();
}
private:
- SkBitmap fBitmap;
- SkBitmap fCheckerboard;
-
typedef GM INHERITED;
+ SkBitmap fBitmap, fCheckerboard;
+ bool fInitialized;
};
//////////////////////////////////////////////////////////////////////////////
-DEF_GM( return SkNEW(TileImageFilterGM); )
+static GM* MyFactory(void*) { return new TileImageFilterGM; }
+static GMRegistry reg(MyFactory);
}
« no previous file with comments | « gm/bigtileimagefilter.cpp ('k') | include/effects/SkTileImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698