Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1143083005: Replace ScriptStreamerTask with blink::Task and threadSafeBind() (Closed)

Created:
5 years, 7 months ago by hiroshige
Modified:
5 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace ScriptStreamerTask with blink::Task and threadSafeBind() This is to - make cross-thread task posting explicit, and - reduce cross-thread data passing outside threadSafeBind(). BUG=478194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196047

Patch Set 1 #

Patch Set 2 : Use threadSafeBind(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -21 lines) Patch
M Source/bindings/core/v8/ScriptStreamer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerThread.h View 2 chunks +2 lines, -12 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamerThread.cpp View 1 chunk +4 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143083005/1
5 years, 6 months ago (2015-05-28 05:28:31 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-28 06:53:21 UTC) #4
haraken
Would you add a more detailed description?
5 years, 6 months ago (2015-05-28 06:59:17 UTC) #5
hiroshige
On 2015/05/28 06:59:17, haraken wrote: > Would you add a more detailed description? Added. (also ...
5 years, 6 months ago (2015-05-28 08:15:10 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143083005/20001
5 years, 6 months ago (2015-05-28 08:15:35 UTC) #9
haraken
LGTM
5 years, 6 months ago (2015-05-28 08:25:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143083005/20001
5 years, 6 months ago (2015-05-28 08:33:42 UTC) #13
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 09:38:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196047

Powered by Google App Engine
This is Rietveld 408576698