Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: Source/bindings/core/v8/ScriptStreamerThread.cpp

Issue 1143083005: Replace ScriptStreamerTask with blink::Task and threadSafeBind() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use threadSafeBind(). Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptStreamerThread.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/ScriptStreamerThread.h" 6 #include "bindings/core/v8/ScriptStreamerThread.h"
7 7
8 #include "bindings/core/v8/ScriptStreamer.h" 8 #include "bindings/core/v8/ScriptStreamer.h"
9 #include "platform/Task.h" 9 #include "platform/Task.h"
10 #include "platform/TraceEvent.h" 10 #include "platform/TraceEvent.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 m_runningTask = false; 70 m_runningTask = false;
71 } 71 }
72 72
73 WebThread& ScriptStreamerThread::platformThread() 73 WebThread& ScriptStreamerThread::platformThread()
74 { 74 {
75 if (!isRunning()) 75 if (!isRunning())
76 m_thread = adoptPtr(Platform::current()->createThread("ScriptStreamerThr ead")); 76 m_thread = adoptPtr(Platform::current()->createThread("ScriptStreamerThr ead"));
77 return *m_thread; 77 return *m_thread;
78 } 78 }
79 79
80 ScriptStreamingTask::ScriptStreamingTask(WTF::PassOwnPtr<v8::ScriptCompiler::Scr iptStreamingTask> task, ScriptStreamer* streamer) 80 void ScriptStreamerThread::runScriptStreamingTask(WTF::PassOwnPtr<v8::ScriptComp iler::ScriptStreamingTask> task, ScriptStreamer* streamer)
81 : m_v8Task(task), m_streamer(streamer) { }
82
83 void ScriptStreamingTask::run()
84 { 81 {
85 TRACE_EVENT0("v8", "v8.parseOnBackground"); 82 TRACE_EVENT0("v8", "v8.parseOnBackground");
86 // Running the task can and will block: SourceStream::GetSomeData will get 83 // Running the task can and will block: SourceStream::GetSomeData will get
87 // called and it will block and wait for data from the network. 84 // called and it will block and wait for data from the network.
88 m_v8Task->Run(); 85 task->Run();
89 m_streamer->streamingCompleteOnBackgroundThread(); 86 streamer->streamingCompleteOnBackgroundThread();
90 MutexLocker locker(*s_mutex); 87 MutexLocker locker(*s_mutex);
91 ScriptStreamerThread* thread = ScriptStreamerThread::shared(); 88 ScriptStreamerThread* thread = shared();
92 if (thread) 89 if (thread)
93 thread->taskDone(); 90 thread->taskDone();
94 // If thread is 0, we're shutting down. 91 // If thread is 0, we're shutting down.
95 } 92 }
96 93
97 } // namespace blink 94 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptStreamerThread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698