Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1143053004: Simplify memory package interface. (Closed)

Created:
5 years, 6 months ago by iannucci
Modified:
5 years, 6 months ago
Reviewers:
Vadim Sh., M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : better comment #

Patch Set 3 : switch to blasters #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -64 lines) Patch
M go/src/infra/gae/libs/meta/eg_test.go View 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/gae/libs/wrapper/gae/context.go View 1 2 2 chunks +20 lines, -9 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/gae/datastore.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/gae/globalinfo.go View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/gae/memcache.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/gae/taskqueue.go View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/context.go View 1 2 2 chunks +20 lines, -10 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/datastore.go View 1 chunk +2 lines, -2 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/datastore_data.go View 4 chunks +4 lines, -4 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/datastore_test.go View 4 chunks +9 lines, -9 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/globalinfo.go View 1 chunk +2 lines, -2 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/key.go View 3 chunks +10 lines, -10 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/key_test.go View 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/memcache.go View 1 chunk +2 lines, -2 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/memcache_test.go View 1 chunk +1 line, -1 line 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/taskqueue.go View 1 chunk +1 line, -3 lines 0 comments Download
M go/src/infra/gae/libs/wrapper/memory/taskqueue_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (1 generated)
iannucci
5 years, 6 months ago (2015-05-29 21:59:52 UTC) #1
iannucci
On 2015/05/29 21:59:52, iannucci wrote: Yes, I realize I should have done this in the ...
5 years, 6 months ago (2015-05-29 22:00:37 UTC) #2
M-A Ruel
Will you update http://godoc.org/chromium.googlesource.com/infra/infra.git/go/src/infra/gae/libs/wrapper/gae too? lgtm
5 years, 6 months ago (2015-05-29 23:00:50 UTC) #3
iannucci
On 2015/05/29 23:00:50, M-A Ruel wrote: > Will you update > http://godoc.org/chromium.googlesource.com/infra/infra.git/go/src/infra/gae/libs/wrapper/gae > too? > ...
5 years, 6 months ago (2015-05-29 23:06:00 UTC) #4
iannucci
PTAL, switched to phasers (just check+panic in Use if you call it on the same ...
5 years, 6 months ago (2015-05-29 23:18:25 UTC) #5
M-A Ruel
lgtm
5 years, 6 months ago (2015-05-29 23:30:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143053004/40001
5 years, 6 months ago (2015-05-30 00:12:43 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-30 00:28:58 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/infra/infra/+/2de36c1308606542d983a8b63d6f8...

Powered by Google App Engine
This is Rietveld 408576698