Issue 1143013002: Remove mojo::InterfaceImpl from device/serial.

Issue 1143013002: Remove mojo::InterfaceImpl from device/serial. (Closed)

Created:
5 years, 7 months ago by Sam McNally

Modified:
5 years, 7 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove mojo::InterfaceImpl from device/serial. BUG=489751 Committed: https://crrev.com/a6faceeb923420b8f8ec83029ecda0fffac5438f Cr-Commit-Position: refs/heads/master@{#330698}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -51 lines)			Patch
M	device/serial/serial_connection.h	View	3 chunks	+7 lines, -4 lines	0 comments	Download
M	device/serial/serial_connection.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	device/serial/serial_connection_factory.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	device/serial/serial_connection_unittest.cc	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	device/serial/serial_service_impl.h	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	device/serial/serial_service_impl.cc	View	2 chunks	+11 lines, -8 lines	0 comments	Download
M	device/serial/serial_service_unittest.cc	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	extensions/browser/api/serial/serial_apitest.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	extensions/renderer/api/serial/serial_api_unittest.cc	View	1 chunk	+7 lines, -8 lines	0 comments	Download

Total messages: 11 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143013002/20001

5 years, 7 months ago (2015-05-20 04:46:56 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143013002/20001

5 years, 7 months ago (2015-05-20 04:49:09 UTC) #9

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 04:53:41 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a6faceeb923420b8f8ec83029ecda0fffac5438f
Cr-Commit-Position: refs/heads/master@{#330698}