Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: device/serial/serial_service_impl.cc

Issue 1143013002: Remove mojo::InterfaceImpl from device/serial. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/serial_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_service_impl.cc
diff --git a/device/serial/serial_service_impl.cc b/device/serial/serial_service_impl.cc
index 22734c89c9273e03d760043623cd60e65222368d..98ae1e02756bafce6e7f4ba4b4f84c602b3a6491 100644
--- a/device/serial/serial_service_impl.cc
+++ b/device/serial/serial_service_impl.cc
@@ -11,15 +11,18 @@
namespace device {
SerialServiceImpl::SerialServiceImpl(
- scoped_refptr<SerialConnectionFactory> connection_factory)
- : connection_factory_(connection_factory) {
+ scoped_refptr<SerialConnectionFactory> connection_factory,
+ mojo::InterfaceRequest<serial::SerialService> request)
+ : connection_factory_(connection_factory), binding_(this, request.Pass()) {
}
SerialServiceImpl::SerialServiceImpl(
scoped_refptr<SerialConnectionFactory> connection_factory,
- scoped_ptr<SerialDeviceEnumerator> device_enumerator)
+ scoped_ptr<SerialDeviceEnumerator> device_enumerator,
+ mojo::InterfaceRequest<serial::SerialService> request)
: device_enumerator_(device_enumerator.Pass()),
- connection_factory_(connection_factory) {
+ connection_factory_(connection_factory),
+ binding_(this, request.Pass()) {
}
SerialServiceImpl::~SerialServiceImpl() {
@@ -30,12 +33,12 @@ void SerialServiceImpl::Create(
scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner,
mojo::InterfaceRequest<serial::SerialService> request) {
- mojo::BindToRequest(
- new SerialServiceImpl(new SerialConnectionFactory(
+ new SerialServiceImpl(
+ new SerialConnectionFactory(
base::Bind(SerialIoHandler::Create,
base::ThreadTaskRunnerHandle::Get(), ui_task_runner),
- io_task_runner)),
- &request);
+ io_task_runner),
+ request.Pass());
}
// static
« no previous file with comments | « device/serial/serial_service_impl.h ('k') | device/serial/serial_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698