Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1142913004: Revert of Add support for backgrounding processes on the Mac (Closed)

Created:
5 years, 7 months ago by Thiemo Nagel
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam, pink (ping after 24hrs), Zhenyao Mo, Jamie Madill
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for backgrounding processes on the Mac (patchset #22 id:420001 of https://codereview.chromium.org/989703002/) Reason for revert: This CL seems to be the cause of ExtensionApiNewTabTest.Tabs failures on Mac. Original issue's description: > Add support for backgrounding processes on the Mac > > Added process_mac.cc with implementations of IsProcessBackgrounded() and > SetProcessBackgrounded(). > > BUG=460102 > > Originally Committed: https://crrev.com/e3bb10f7860a1d553c85293bd7d7615c0e7f0fd9 > Reverted: https://crrev.com/ce6226a7ffe2c1cb7ac5f6cf34b56b8d217686b9 > > Committed: https://crrev.com/0160d130f8a4462fa7bfb8a9924e476d31ba9a48 > Cr-Commit-Position: refs/heads/master@{#330464} TBR=rsesek@chromium.org,gab@chromium.org,thakis@chromium.org,asvitkine@chromium.org,avi@chromium.org,kbr@chromium.org,shrike@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460102 Committed: https://crrev.com/93ef7cd278d450b06f4a95fad6577d05b67624aa Cr-Commit-Position: refs/heads/master@{#330519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -197 lines) Patch
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/process/process.h View 3 chunks +2 lines, -20 lines 0 comments Download
D base/process/process_mac.cc View 1 chunk +0 lines, -126 lines 0 comments Download
M base/process/process_posix.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M base/process/process_unittest.cc View 3 chunks +2 lines, -24 lines 0 comments Download
M content/browser/child_process_launcher.cc View 2 chunks +1 line, -9 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Thiemo Nagel
Created Revert of Add support for backgrounding processes on the Mac
5 years, 7 months ago (2015-05-19 14:25:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142913004/1
5 years, 7 months ago (2015-05-19 14:26:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 14:26:57 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 14:27:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93ef7cd278d450b06f4a95fad6577d05b67624aa
Cr-Commit-Position: refs/heads/master@{#330519}

Powered by Google App Engine
This is Rietveld 408576698