Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1142913004: Revert of Add support for backgrounding processes on the Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/child_process_launcher.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Represents the browser side of the browser <--> renderer communication 5 // Represents the browser side of the browser <--> renderer communication
6 // channel. There will be one RenderProcessHost per renderer process. 6 // channel. There will be one RenderProcessHost per renderer process.
7 7
8 #include "content/browser/renderer_host/render_process_host_impl.h" 8 #include "content/browser/renderer_host/render_process_host_impl.h"
9 9
10 #include <algorithm> 10 #include <algorithm>
11 #include <limits> 11 #include <limits>
(...skipping 2197 matching lines...) Expand 10 before | Expand all | Expand 10 after
2209 // The cbstext.dll loads as a global GetMessage hook in the browser process 2209 // The cbstext.dll loads as a global GetMessage hook in the browser process
2210 // and intercepts/unintercepts the kernel32 API SetPriorityClass in a 2210 // and intercepts/unintercepts the kernel32 API SetPriorityClass in a
2211 // background thread. If the UI thread invokes this API just when it is 2211 // background thread. If the UI thread invokes this API just when it is
2212 // intercepted the stack is messed up on return from the interceptor 2212 // intercepted the stack is messed up on return from the interceptor
2213 // which causes random crashes in the browser process. Our hack for now 2213 // which causes random crashes in the browser process. Our hack for now
2214 // is to not invoke the SetPriorityClass API if the dll is loaded. 2214 // is to not invoke the SetPriorityClass API if the dll is loaded.
2215 if (GetModuleHandle(L"cbstext.dll")) 2215 if (GetModuleHandle(L"cbstext.dll"))
2216 return; 2216 return;
2217 #endif // OS_WIN 2217 #endif // OS_WIN
2218 2218
2219 #if defined(OS_WIN) || defined(OS_MACOSX) 2219 #if defined(OS_WIN)
2220 // Same as below, but bound to an experiment (http://crbug.com/458594 on 2220 // Same as below, but bound to an experiment (http://crbug.com/458594)
2221 // Windows, http://crbug.com/398103 on the Mac). Enabled by default in the 2221 // initially on Windows. Enabled by default in the asbence of field trials to
2222 // absence of field trials to get coverage on the perf waterfall. 2222 // get coverage on the perf waterfall.
2223 base::FieldTrial* trial = 2223 base::FieldTrial* trial =
2224 base::FieldTrialList::Find("BackgroundRendererProcesses"); 2224 base::FieldTrialList::Find("BackgroundRendererProcesses");
2225 if (!trial || !StartsWithASCII(trial->group_name(), "Disallow", true)) { 2225 if (!trial || trial->group_name() != "Disallow")
2226 child_process_launcher_->SetProcessBackgrounded(backgrounded); 2226 child_process_launcher_->SetProcessBackgrounded(backgrounded);
2227 }
2228 #else 2227 #else
2229 // Control the background state from the browser process, otherwise the task 2228 // Control the background state from the browser process, otherwise the task
2230 // telling the renderer to "unbackground" itself may be preempted by other 2229 // telling the renderer to "unbackground" itself may be preempted by other
2231 // tasks executing at lowered priority ahead of it or simply by not being 2230 // tasks executing at lowered priority ahead of it or simply by not being
2232 // swiftly scheduled by the OS per the low process priority 2231 // swiftly scheduled by the OS per the low process priority
2233 // (http://crbug.com/398103). 2232 // (http://crbug.com/398103).
2234 child_process_launcher_->SetProcessBackgrounded(backgrounded); 2233 child_process_launcher_->SetProcessBackgrounded(backgrounded);
2235 #endif // OS_WIN 2234 #endif // OS_WIN
2236 2235
2237 // Notify the child process of background state. 2236 // Notify the child process of background state.
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
2459 if (worker_ref_count_ == 0) 2458 if (worker_ref_count_ == 0)
2460 Cleanup(); 2459 Cleanup();
2461 } 2460 }
2462 2461
2463 void RenderProcessHostImpl::GetAudioOutputControllers( 2462 void RenderProcessHostImpl::GetAudioOutputControllers(
2464 const GetAudioOutputControllersCallback& callback) const { 2463 const GetAudioOutputControllersCallback& callback) const {
2465 audio_renderer_host()->GetOutputControllers(callback); 2464 audio_renderer_host()->GetOutputControllers(callback);
2466 } 2465 }
2467 2466
2468 } // namespace content 2467 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/child_process_launcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698