Issue 1142853003: cc: Make TransformNodeData scroll offset a ScrollOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142853003: cc: Make TransformNodeData scroll offset a ScrollOffset (Closed)

Created:
5 years, 7 months ago by enne (OOO)

Modified:
5 years, 7 months ago

Reviewers:
Ian Vollick, ajuma

CC:
cc-bugs_chromium.org, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

cc: Make TransformNodeData scroll offset a ScrollOffset Rather than converting everywhere from ScrollOffset to Vector2dF, instead just store the scroll offset directly. R=ajuma@chromium.org,vollick@chromium.org Committed: https://crrev.com/2992454688568ddd53f76bb228d72a5fd5403451 Cr-Commit-Position: refs/heads/master@{#330533}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -9 lines)			Patch
M	cc/layers/layer.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	cc/trees/property_tree.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	cc/trees/property_tree_builder.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142853003/1

5 years, 7 months ago (2015-05-19 16:57:51 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 17:12:47 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/2992454688568ddd53f76bb228d72a5fd5403451
Cr-Commit-Position: refs/heads/master@{#330533}