Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 11428143: Revert 170740 (Closed)

Created:
8 years ago by Zhenyao Mo
Modified:
8 years ago
Reviewers:
robertphillips
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 170740 Broke bunch of layout tests on Mac: canvas/philip/tests/2d.text.draw.align.center.html,canvas/philip/tests/2d.text.draw.align.end.ltr.html,canvas/philip/tests/2d.text.draw.align.end.rtl.html,canvas/philip/tests/2d.text.draw.align.left.html,canvas/philip/tests/2d.text.draw.align.right.html,canvas/philip/tests/2d.text.draw.align.start.ltr.html,canvas/philip/tests/2d.text.draw.align.start.rtl.html,canvas/philip/tests/2d.text.draw.baseline.alphabetic.html,canvas/philip/tests/2d.text.draw.baseline.ideographic.html,canvas/philip/tests/2d.text.draw.fill.maxWidth.bound.html,canvas/philip/tests/2d.text.draw.fontface.html,canvas/philip/tests/2d.text.draw.fontface.repeat.html,canvas/philip/tests/2d.text.draw.space.basic.html,canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.center.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.end.ltr.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.end.rtl.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.left.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.right.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.start.ltr.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.align.start.rtl.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.alphabetic.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.baseline.ideographic.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fill.maxWidth.bound.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.fontface.repeat.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.space.basic.html,platform/chromium/virtual/gpu/canvas/philip/tests/2d.text.draw.space.collapse.nonspace.html > Roll Skia DEPS to r6641 & add suppressions > > control: https://codereview.chromium.org/11418289/ > Review URL: https://codereview.chromium.org/11412301 TBR=robertphillips@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 chunk +67 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
8 years ago (2012-12-03 18:59:27 UTC) #1
robertphillips
8 years ago (2012-12-03 19:15:47 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698