Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 11412301: Roll Skia DEPS to r6641 & add suppressions (Closed)

Created:
8 years ago by robertphillips
Modified:
8 years ago
Reviewers:
Stephen Chennney, reed1
CC:
chromium-reviews, skia-dev_google.com, hwennborg, Stephen Chennney
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -72 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia.gyp View 1 chunk +0 lines, -4 lines 1 comment Download
M skia/skia_test_expectations.txt View 1 chunk +2 lines, -67 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
robertphillips
I think this is 'good'. This CL shows that the shadow-drawing test has been suppressed ...
8 years ago (2012-12-03 15:12:23 UTC) #1
Stephen Chennney
8 years ago (2012-12-03 15:13:59 UTC) #2
LGTM

Notes are for tomorrow's roll.

https://codereview.chromium.org/11412301/diff/1/skia/skia.gyp
File skia/skia.gyp (left):

https://codereview.chromium.org/11412301/diff/1/skia/skia.gyp#oldcode239
skia/skia.gyp:239: 'SK_DISABLE_SEPARABLE_MASK_BLUR',
This was added to WebKit's skia gyp in r136271 and WebKit has now rolled to
r136275 in Chromium. So this line can be removed too.

https://codereview.chromium.org/11412301/diff/1/skia/skia_test_expectations.txt
File skia/skia_test_expectations.txt (right):

https://codereview.chromium.org/11412301/diff/1/skia/skia_test_expectations.t...
skia/skia_test_expectations.txt:56: crbug.com/161762 
svg/carto.net/colourpicker.svg [ Crash ImageOnlyFailure ]
Rebaselined in WebKit http://trac.webkit.org/changeset/136396

https://codereview.chromium.org/11412301/diff/1/skia/skia_test_expectations.t...
skia/skia_test_expectations.txt:59: crbug.com/161899
platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing.html [
Failure ImageOnlyFailure ]
Ditto.

Powered by Google App Engine
This is Rietveld 408576698