Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 11428103: Revert "Perform CPU sampling by CPU sampling thread only iff processing thread is not running." (Closed)

Created:
8 years ago by Jakob Kummerow
Modified:
8 years ago
Reviewers:
danno
CC:
v8-dev, caseq
Visibility:
Public.

Description

Revert "Perform CPU sampling by CPU sampling thread only iff processing thread is not running." This reverts r12985. Committed: http://code.google.com/p/v8/source/detail?r=13104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -319 lines) Patch
M src/cpu-profiler.h View 4 chunks +8 lines, -20 lines 0 comments Download
M src/cpu-profiler.cc View 7 chunks +40 lines, -52 lines 0 comments Download
M src/cpu-profiler-inl.h View 2 chunks +5 lines, -11 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/platform.h View 3 chunks +4 lines, -26 lines 0 comments Download
M src/platform-cygwin.cc View 4 chunks +1 line, -15 lines 0 comments Download
M src/platform-freebsd.cc View 4 chunks +1 line, -15 lines 0 comments Download
M src/platform-linux.cc View 15 chunks +47 lines, -84 lines 0 comments Download
M src/platform-macos.cc View 4 chunks +1 line, -15 lines 0 comments Download
M src/platform-nullos.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/platform-openbsd.cc View 4 chunks +1 line, -15 lines 0 comments Download
M src/platform-solaris.cc View 4 chunks +1 line, -16 lines 0 comments Download
M src/platform-win32.cc View 4 chunks +1 line, -15 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 10 chunks +18 lines, -23 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
8 years ago (2012-11-30 10:18:23 UTC) #1
danno
8 years ago (2012-11-30 10:19:26 UTC) #2
rubber-stamp lgtm

Powered by Google App Engine
This is Rietveld 408576698