Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: src/platform-win32.cc

Issue 11428103: Revert "Perform CPU sampling by CPU sampling thread only iff processing thread is not running." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/platform-solaris.cc ('k') | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/platform-win32.cc
diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index 261a946a869802cee9646eb1db7ec0939acc587c..b3ca40294d3de67b32464d7c933249d27276a199 100644
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -2054,7 +2054,7 @@ class SamplerThread : public Thread {
memset(&context, 0, sizeof(context));
TickSample sample_obj;
- TickSample* sample = CpuProfiler::StartTickSampleEvent(sampler->isolate());
+ TickSample* sample = CpuProfiler::TickSampleEvent(sampler->isolate());
if (sample == NULL) sample = &sample_obj;
static const DWORD kSuspendFailed = static_cast<DWORD>(-1);
@@ -2075,7 +2075,6 @@ class SamplerThread : public Thread {
sampler->SampleStack(sample);
sampler->Tick(sample);
}
- CpuProfiler::FinishTickSampleEvent(sampler->isolate());
ResumeThread(profiled_thread);
}
@@ -2130,11 +2129,6 @@ Sampler::~Sampler() {
}
-void Sampler::DoSample() {
- // TODO(rogulenko): implement
-}
-
-
void Sampler::Start() {
ASSERT(!IsActive());
SetActive(true);
@@ -2149,12 +2143,4 @@ void Sampler::Stop() {
}
-void Sampler::StartSampling() {
-}
-
-
-void Sampler::StopSampling() {
-}
-
-
} } // namespace v8::internal
« no previous file with comments | « src/platform-solaris.cc ('k') | test/cctest/test-cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698