Issue 11428099: Use skia::RefPtr in place of manual ref-counting for Skia types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428099: Use skia::RefPtr in place of manual ref-counting for Skia types. (Closed)

Created:
8 years ago by danakj

Modified:
8 years ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, piman, backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use skia::RefPtr in place of manual ref-counting for Skia types. This covers remaining content/ and webkit/ manual ref-counting. BUG=163454 R=piman Depends on: https://codereview.chromium.org/11418217/ NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170879

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -33 lines)			Patch
M	content/plugin/webplugin_proxy.h	View	1	6 chunks	+8 lines, -9 lines	0 comments	Download
M	content/plugin/webplugin_proxy.cc	View		5 chunks	+16 lines, -16 lines	0 comments	Download
M	content/renderer/render_widget.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppb_flash_impl.cc	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11428099/2001

8 years ago (2012-12-04 00:41:07 UTC) #3

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) browser_tests

8 years ago (2012-12-04 03:41:04 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11428099/2001

8 years ago (2012-12-04 03:43:08 UTC) #5

Message was sent while issue was closed.

Change committed as 170879