Migrate the Android compositor to cc::Layer classes.

Migrate the Android compositor to cc::Layer classes.


BUG=163210
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170737

[Leandro Graciá Gil, 2012-11-29 20:57:26]

aelias: content/browser/renderer_host  Android specifics.
Yaron: content/browser/android
jamesr: generic overview and cc/ + webkit/
joth: android_webview/

This will require a downstream side that has to be landed in coordination with
this patch. I hope this makes things a lot simpler for many of us.

[jamesr, 2012-11-29 21:04:46]

lgtm

great!

[joth, 2012-11-29 21:19:38]

lgtm.

https://codereview.chromium.org/11428091/diff/1/content/browser/android/conte...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/11428091/diff/1/content/browser/android/conte...
content/browser/android/content_view_core_impl.cc:61: using cc::Layer;
nit: rather than using, I think saying cc::Layer at usage site is actually
easier to understand.

https://codereview.chromium.org/11428091/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/11428091/diff/1/content/browser/renderer_host...
content/browser/renderer_host/compositor_impl_android.cc:319: return ret.Pass();
wrong indent

I think just "return scoped_ptr<cc::InputHandler>(); is OK.

[Yaron, 2012-11-29 21:25:56]

lgtm

[aelias_OOO_until_Jul13, 2012-11-30 04:33:06]

https://codereview.chromium.org/11428091/diff/1/webkit/compositor_bindings/we...
File webkit/compositor_bindings/web_layer_tree_view_impl.cc (left):

https://codereview.chromium.org/11428091/diff/1/webkit/compositor_bindings/we...
webkit/compositor_bindings/web_layer_tree_view_impl.cc:42:
settings.implSidePainting =
CommandLine::ForCurrentProcess()->HasSwitch(cc::switches::kEnableImplSidePainting);
I don't think you should be deleting this line?  Rebase error?

[Leandro Graciá Gil, 2012-11-30 10:42:50]

https://codereview.chromium.org/11428091/diff/1/webkit/compositor_bindings/we...
File webkit/compositor_bindings/web_layer_tree_view_impl.cc (left):

https://codereview.chromium.org/11428091/diff/1/webkit/compositor_bindings/we...
webkit/compositor_bindings/web_layer_tree_view_impl.cc:42:
settings.implSidePainting =
CommandLine::ForCurrentProcess()->HasSwitch(cc::switches::kEnableImplSidePainting);
On 2012/11/30 04:33:07, aelias wrote:
> I don't think you should be deleting this line?  Rebase error?

I'm not deleting it, but moving it to layer_tree_host.cc with the rest of
switch-defined settings for simplicity.

[Leandro Graciá Gil, 2012-11-30 12:11:11]

https://codereview.chromium.org/11428091/diff/1/content/browser/android/conte...
File content/browser/android/content_view_core_impl.cc (right):

https://codereview.chromium.org/11428091/diff/1/content/browser/android/conte...
content/browser/android/content_view_core_impl.cc:61: using cc::Layer;
On 2012/11/29 21:19:38, joth wrote:
> nit: rather than using, I think saying cc::Layer at usage site is actually
> easier to understand. 

Done.

https://codereview.chromium.org/11428091/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/compositor_impl_android.cc (right):

https://codereview.chromium.org/11428091/diff/1/content/browser/renderer_host...
content/browser/renderer_host/compositor_impl_android.cc:319: return ret.Pass();
On 2012/11/29 21:19:38, joth wrote:
> wrong indent
> 
> I think just "return scoped_ptr<cc::InputHandler>(); is OK.

Done.

[aelias_OOO_until_Jul13, 2012-11-30 19:17:56]

lgtm