Inline hot ctor/dtors for struct-like gfx:: geometry types

Inline hot ctor/dtors for struct-like gfx:: geometry types

This inlines the ctors and (empty) dtors for gfx::PointF, SizeF and RectF. On
a ToT chromium mac release build, inlining these is a 8.5% speedup on cc_perftests.
Based on profiling data from instruments inlining QuadF would be a speedup as well,
but the chromium-style plugin thinks it's too complex (even though the dtor has no
code).

BUG=
NOTRY=true (yoda style)


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170378

[jamesr, 2012-11-29 10:03:27]

Dana - please review

sky - cc'ing as an FYI.

[jamesr, 2012-11-29 10:24:45]

Also inlining the int versions of size/point/rect (since they showed up next in
the profile) brings the total speedup to 12.1%

[danakj, 2012-11-29 18:36:44]

LGTM+nits

Did you try moving cons/destructors from rect_base_impl.h to rect_base.h as
well?

Do you have an idea why clang won't let you move QuadF's?

https://codereview.chromium.org/11428076/diff/3002/ui/gfx/rect.h
File ui/gfx/rect.h (right):

https://codereview.chromium.org/11428076/diff/3002/ui/gfx/rect.h#newcode48
ui/gfx/rect.h:48: Size(width, height)) {}
the rect_f.h changes look a lot cleaner than these style-wise, can you make
these more like those?

https://codereview.chromium.org/11428076/diff/3002/ui/gfx/rect.h#newcode62
ui/gfx/rect.h:62: : RectBase<Rect, Point, Size, Insets, Vector2d, int> (origin,
size) {}
should be 4 spaces before : right?

[jamesr, 2012-11-29 22:40:40]

https://codereview.chromium.org/11428076/diff/3002/ui/gfx/rect.h
File ui/gfx/rect.h (right):

https://codereview.chromium.org/11428076/diff/3002/ui/gfx/rect.h#newcode48
ui/gfx/rect.h:48: Size(width, height)) {}
On 2012/11/29 18:36:44, danakj wrote:
> the rect_f.h changes look a lot cleaner than these style-wise, can you make
> these more like those?

I can try to reformat to match that.  There's no really good way to wrap these
since the fully qualified type name of the base class is pretty close to 80col
and I don't think we can safely typedef it to anything in the header.  Will take
another crack.

[commit-bot: I haz the power, 2012-11-29 23:03:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11428076/1013

[commit-bot: I haz the power, 2012-11-29 23:53:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-30 00:15:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11428076/1013

[commit-bot: I haz the power, 2012-11-30 00:26:08]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[danakj, 2012-11-30 01:04:50]

i'd NOTRY=true this

[commit-bot: I haz the power, 2012-11-30 01:08:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/11428076/1013

[commit-bot: I haz the power, 2012-11-30 03:34:39]

Change committed as 170378