Inline hot ctor/dtors for struct-like gfx:: geometry types

ui/gfx/rect.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines a simple integer rectangle class.  The containment semantics
 // are array-like; that is, the coordinate (x, y) is considered to be
 // contained by the rectangle, but the coordinate (x + width, y) is not.
 // The class will happily let you create malformed rectangles (that is,
 // rectangles with negative width and/or height), but there will be assertions
 // in the operations (such as Contains()) to complain in this case.
@@ skipping 19 matching lines @@
 #include <ApplicationServices/ApplicationServices.h>
 #endif
 
 namespace gfx {
 
 class Insets;
 
 class UI_EXPORT Rect
     : public RectBase<Rect, Point, Size, Insets, Vector2d, int> {
  public:
-  Rect();
-  Rect(int width, int height);
-  Rect(int x, int y, int width, int height);
+  Rect() : RectBase<Rect, Point, Size, Insets, Vector2d, int> (Point()) {}
+
+  Rect(int width, int height)
+    : RectBase<Rect, Point, Size, Insets, Vector2d, int> (Size(width, height))
+  {}
+
+  Rect(int x, int y, int width, int height)
+    : RectBase<Rect, Point, Size, Insets, Vector2d, int>(Point(x, y),
+                                                         Size(width, height)) {}

[danakj, 2012/11/29 18:36:44]

the rect_f.h changes look a lot cleaner than these style-wise, can you make
these more like those?

[jamesr, 2012/11/29 22:40:40]

I can try to reformat to match that.  There's no really good way to wrap these
since the fully qualified type name of the base class is pretty close to 80col
and I don't think we can safely typedef it to anything in the header.  Will take
another crack.

+
 #if defined(OS_WIN)
   explicit Rect(const RECT& r);
 #elif defined(OS_MACOSX)
   explicit Rect(const CGRect& r);
 #elif defined(TOOLKIT_GTK)
   explicit Rect(const GdkRectangle& r);
 #endif
-  explicit Rect(const gfx::Size& size);
-  Rect(const gfx::Point& origin, const gfx::Size& size);
 
-  ~Rect();
+  explicit Rect(const gfx::Size& size)
+      : RectBase<Rect, Point, Size, Insets, Vector2d, int> (size) {}
+
+  Rect(const gfx::Point& origin, const gfx::Size& size)
+    : RectBase<Rect, Point, Size, Insets, Vector2d, int> (origin, size) {}

[danakj, 2012/11/29 18:36:44]

should be 4 spaces before : right?

+
+  ~Rect() {}
 
 #if defined(OS_WIN)
   // Construct an equivalent Win32 RECT object.
   RECT ToRECT() const;
 #elif defined(TOOLKIT_GTK)
   GdkRectangle ToGdkRectangle() const;
 #elif defined(OS_MACOSX)
   // Construct an equivalent CoreGraphics object.
   CGRect ToCGRect() const;
 #endif
@@ skipping 32 matching lines @@
 // contained within the rect, because they will appear on one of these edges.
 UI_EXPORT Rect BoundingRect(const Point& p1, const Point& p2);
 
 #if !defined(COMPILER_MSVC)
 extern template class RectBase<Rect, Point, Size, Insets, Vector2d, int>;
 #endif
 
 }  // namespace gfx
 
 #endif  // UI_GFX_RECT_H_