Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 11428030: Revert 169670 (Still no dice on cros, I updated crbug.com/159580 with the problem) (Closed)

Created:
8 years ago by Nico
Modified:
8 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 169670 (Still no dice on cros, I updated crbug.com/159580 with the problem) - Revert 169592: Now that the libvpx roll is in, this should work. - Revert 169589: Caused a bunch of chromeos-chrome-25.0.1336.0_alpha-r1: /var/cache/chromeos-cache/distfiles/target/chrome-src/src/third_party/libvpx/source/libvpx/vp8/encoder/x86/quantize_sse2.asm:58: error: undefined symbol `vp8_block_coeff' (first use) Likely because third_party/libvpx/libvpx.gyp still uses the old form. - Use new -fsanitize=address instead of deprecated -faddress-sanitizer BUG=159580, 162783 Review URL: https://codereview.chromium.org/11416192 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/11411191 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/11308229 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M build/common.gypi View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years ago (2012-11-27 18:30:07 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698