Use new -fsanitize=address instead of deprecated -faddress-sanitizer

Use new -fsanitize=address instead of deprecated -faddress-sanitizer

BUG=159580, 162783
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169589

[Nico, 2012-11-27 02:14:49]

The try job fails with:

FAILED: clang -MMD -MF
obj/third_party/webrtc/modules/audio_coding/codecs/g722/g722.g722_encode.o.d
'-DWEBRTC_SVNREVISION="Unavailable(issue687)"' -D_FORTIFY_SOURCE=2
-DADDRESS_SANITIZER -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DENABLE_PEPPER_THREADING -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDCHECK_ALWAYS_ON=1 -DENABLE_GPU=1
-DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1
-DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_LANGUAGE_DETECTION=1
-DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DWEBRTC_CHROMIUM_BUILD
-DWEBRTC_MAC -DWEBRTC_THREAD_RR -DWEBRTC_CLOCK_TYPE_REALTIME
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/webrtc -I../../third_party
-I../../third_party/webrtc/modules/audio_coding/codecs/g722/include -isysroot
/Developer/SDKs/MacOSX10.6.sdk -O3 -gdwarf-2 -fvisibility=hidden -Werror
-Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene
-Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args
-Wno-c++11-extensions -Wno-covered-switch-default -std=c99 -fsanitize=address
-Xclang -load -Xclang
/Volumes/data/b/build/slave/mac_asan/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations
-fcolor-diagnostics -fno-strict-aliasing  -c
../../third_party/webrtc/modules/audio_coding/codecs/g722/g722_encode.c -o
obj/third_party/webrtc/modules/audio_coding/codecs/g722/g722.g722_encode.o
In file included from <built-in>:157:
<command line>:2:9:error: '_FORTIFY_SOURCE' macro redefined [-Werror]
#define _FORTIFY_SOURCE 2
        ^
<built-in>:148:9: note: previous definition is here
#define _FORTIFY_SOURCE 0
        ^
1 error generated.

(
http://build.chromium.org/p/tryserver.chromium/builders/mac_asan/builds/10714...
)

due to us removing -w again. The 2nd define is from Pawel's
https://codereview.chromium.org/11411022 , but I can't find the first define.
glider, do you know if we add that for remoting somewhere?

[Nico, 2012-11-27 05:26:13]

I filed http://crbug.com/162783 for removing -w. I'll land this CL without that
part.

[Nico, 2012-11-27 05:26:35]

(glider lgtm'd over email, but rietveld didn't see it.)

[Alexander Potapenko, 2012-11-27 23:48:50]

Because ASan is unable to remove the extra definition, we need to do
that for ASan builds in GYP.
ASan doesn't work with source fortification well enough.

On Tue, Nov 27, 2012 at 6:22 AM, Alexander Potapenko
<glider@chromium.org> wrote:
> The first define is added by ASan itself, see
> http://llvm.org/viewvc/llvm-project?view=rev&revision=164299
>
> On Tue, Nov 27, 2012 at 6:14 AM,  <thakis@chromium.org> wrote:
>> The try job fails with:
>>
>> FAILED: clang -MMD -MF
>> obj/third_party/webrtc/modules/audio_coding/codecs/g722/g722.g722_encode.o.d
>> '-DWEBRTC_SVNREVISION="Unavailable(issue687)"' -D_FORTIFY_SOURCE=2
>> -DADDRESS_SANITIZER -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1
>> -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
>> -DENABLE_PEPPER_THREADING -DENABLE_CONFIGURATION_POLICY
>> -DENABLE_INPUT_SPEECH
>> -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDCHECK_ALWAYS_ON=1 -DENABLE_GPU=1
>> -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1
>> -DENABLE_WEB_INTENTS=1
>> -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
>> -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
>> -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_LANGUAGE_DETECTION=1
>> -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
>> -DWEBRTC_CHROMIUM_BUILD
>> -DWEBRTC_MAC -DWEBRTC_THREAD_RR -DWEBRTC_CLOCK_TYPE_REALTIME
>> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
>> -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/webrtc
>> -I../../third_party
>> -I../../third_party/webrtc/modules/audio_coding/codecs/g722/include
>> -isysroot
>> /Developer/SDKs/MacOSX10.6.sdk -O3 -gdwarf-2 -fvisibility=hidden -Werror
>> -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels
>> -Wextra
>> -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene
>> -Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args
>> -Wno-c++11-extensions -Wno-covered-switch-default -std=c99
>> -fsanitize=address
>> -Xclang -load -Xclang
>>
/Volumes/data/b/build/slave/mac_asan/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
>> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
>> -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations
>> -fcolor-diagnostics -fno-strict-aliasing  -c
>> ../../third_party/webrtc/modules/audio_coding/codecs/g722/g722_encode.c -o
>> obj/third_party/webrtc/modules/audio_coding/codecs/g722/g722.g722_encode.o
>> In file included from <built-in>:157:
>> <command line>:2:9:error: '_FORTIFY_SOURCE' macro redefined [-Werror]
>> #define _FORTIFY_SOURCE 2
>>         ^
>> <built-in>:148:9: note: previous definition is here
>> #define _FORTIFY_SOURCE 0
>>         ^
>> 1 error generated.
>>
>> (
>>
http://build.chromium.org/p/tryserver.chromium/builders/mac_asan/builds/10714...
>> )
>>
>> due to us removing -w again. The 2nd define is from Pawel's
>> https://codereview.chromium.org/11411022 , but I can't find the first
>> define.
>> glider, do you know if we add that for remoting somewhere?
>>
>> https://codereview.chromium.org/11416192/
>
>
>
> --
> Alexander Potapenko
> Software Engineer
> Google Moscow



-- 
Alexander Potapenko
Software Engineer
Google Moscow

[Alexander Potapenko, 2012-11-27 23:54:03]

The first define is added by ASan itself, see
http://llvm.org/viewvc/llvm-project?view=rev&revision=164299

On Tue, Nov 27, 2012 at 6:14 AM,  <thakis@chromium.org> wrote:
> The try job fails with:
>
> FAILED: clang -MMD -MF
> obj/third_party/webrtc/modules/audio_coding/codecs/g722/g722.g722_encode.o.d
> '-DWEBRTC_SVNREVISION="Unavailable(issue687)"' -D_FORTIFY_SOURCE=2
> -DADDRESS_SANITIZER -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1
> -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
> -DENABLE_PEPPER_THREADING -DENABLE_CONFIGURATION_POLICY
> -DENABLE_INPUT_SPEECH
> -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDCHECK_ALWAYS_ON=1 -DENABLE_GPU=1
> -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1
> -DENABLE_WEB_INTENTS=1
> -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
> -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
> -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_LANGUAGE_DETECTION=1
> -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
> -DWEBRTC_CHROMIUM_BUILD
> -DWEBRTC_MAC -DWEBRTC_THREAD_RR -DWEBRTC_CLOCK_TYPE_REALTIME
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
> -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../third_party/webrtc
> -I../../third_party
> -I../../third_party/webrtc/modules/audio_coding/codecs/g722/include
> -isysroot
> /Developer/SDKs/MacOSX10.6.sdk -O3 -gdwarf-2 -fvisibility=hidden -Werror
> -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels
> -Wextra
> -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene
> -Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args
> -Wno-c++11-extensions -Wno-covered-switch-default -std=c99
> -fsanitize=address
> -Xclang -load -Xclang
>
/Volumes/data/b/build/slave/mac_asan/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
> -Xclang -add-plugin -Xclang find-bad-constructs -Xclang
> -plugin-arg-find-bad-constructs -Xclang skip-virtuals-in-implementations
> -fcolor-diagnostics -fno-strict-aliasing  -c
> ../../third_party/webrtc/modules/audio_coding/codecs/g722/g722_encode.c -o
> obj/third_party/webrtc/modules/audio_coding/codecs/g722/g722.g722_encode.o
> In file included from <built-in>:157:
> <command line>:2:9:error: '_FORTIFY_SOURCE' macro redefined [-Werror]
> #define _FORTIFY_SOURCE 2
>         ^
> <built-in>:148:9: note: previous definition is here
> #define _FORTIFY_SOURCE 0
>         ^
> 1 error generated.
>
> (
>
http://build.chromium.org/p/tryserver.chromium/builders/mac_asan/builds/10714...
> )
>
> due to us removing -w again. The 2nd define is from Pawel's
> https://codereview.chromium.org/11411022 , but I can't find the first
> define.
> glider, do you know if we add that for remoting somewhere?
>
> https://codereview.chromium.org/11416192/



-- 
Alexander Potapenko
Software Engineer
Google Moscow