Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Issue 1142763002: Revert of Mark internal AccessorInfo properties as "special data properties" (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Mark internal AccessorInfo properties as "special data properties" (patchset #2 id:20001 of https://codereview.chromium.org/1123163005/) Reason for revert: [Sheriff] Blocks current roll: https://codereview.chromium.org/1124403007/ Bisection (https://codereview.chromium.org/1142753002/) points to this CL. Original issue's description: > Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling. > > BUG= > > Committed: https://crrev.com/188297160d2b82a4e2a206ebbddfc21dd99a9d8d > Cr-Commit-Position: refs/heads/master@{#28369} TBR=rossberg@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/ac5336baca8c1ee45be0157aa1d4f9a178d75bb6 Cr-Commit-Position: refs/heads/master@{#28437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -37 lines) Patch
M src/accessors.cc View 7 chunks +37 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -10 lines 0 comments Download
M test/mjsunit/array-length.js View 1 chunk +0 lines, -6 lines 0 comments Download
M test/mjsunit/es6/arguments-iterator.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Achenbach
Created Revert of Mark internal AccessorInfo properties as "special data properties"
5 years, 7 months ago (2015-05-17 16:50:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142763002/1
5 years, 7 months ago (2015-05-17 16:50:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-17 16:50:33 UTC) #3
Michael Achenbach
5 years, 7 months ago (2015-05-17 16:51:06 UTC) #5
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1135283004/ by machenbach@chromium.org. ...
5 years, 7 months ago (2015-05-18 09:43:47 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:04:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac5336baca8c1ee45be0157aa1d4f9a178d75bb6
Cr-Commit-Position: refs/heads/master@{#28437}

Powered by Google App Engine
This is Rietveld 408576698