Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1135283004: Revert of Revert of Mark internal AccessorInfo properties as "special data properties" (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Mark internal AccessorInfo properties as "special data properties" (patchset #1 id:1 of https://codereview.chromium.org/1142763002/) Reason for revert: Reland Original issue's description: > Revert of Mark internal AccessorInfo properties as "special data properties" (patchset #2 id:20001 of https://codereview.chromium.org/1123163005/) > > Reason for revert: > [Sheriff] Blocks current roll: > https://codereview.chromium.org/1124403007/ > > Bisection (https://codereview.chromium.org/1142753002/) points to this CL. > > > Original issue's description: > > Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling. > > > > BUG= > > > > Committed: https://crrev.com/188297160d2b82a4e2a206ebbddfc21dd99a9d8d > > Cr-Commit-Position: refs/heads/master@{#28369} > > TBR=rossberg@chromium.org,verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= TBR=rossberg@chromium.org,verwaest@chromium.org,yangguo@chromium.org,vogelheim@chromium.org,hablich@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -47 lines) Patch
M src/accessors.cc View 7 chunks +1 line, -37 lines 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/array-length.js View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/es6/arguments-iterator.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Michael Achenbach
5 years, 7 months ago (2015-05-18 09:43:48 UTC) #1
Created Revert of Revert of Mark internal AccessorInfo properties as "special
data properties"

Powered by Google App Engine
This is Rietveld 408576698