Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1142643004: Revert of Re-enable local video test with better logging and higher tolerance. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable local video test with better logging and higher tolerance. (patchset #4 id:60001 of https://codereview.chromium.org/1108803002/) Reason for revert: still flaky, see http://chromium-try-flakes.appspot.com/search?q=WebRtcBrowserTest.CanSetupVideoCallAndDisableLocalVideo and http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/59522 Original issue's description: > Re-enable local video test with better logging and higher tolerance. > > The test appears to get stuck on waiting for black frames. This patch > adds some logging so we perhaps can learn more where in the image we > find the nonblack pixels. Also trying to increase tolerance for > rounding errors somewhat to see if that helps. > > BUG=477498 > > Committed: https://crrev.com/839a0eb5f8aeff1de8263eff28e55cb8b5fe7396 > Cr-Commit-Position: refs/heads/master@{#329616} TBR=kjellander@chromium.org,tommi@chromium.org,phoglund@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477498 Committed: https://crrev.com/6bfe1b5612e270f8882099e486ad3975fd5b80fb Cr-Commit-Position: refs/heads/master@{#330102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -32 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M content/test/data/media/webrtc_test_utilities.js View 3 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
Created Revert of Re-enable local video test with better logging and higher tolerance.
5 years, 7 months ago (2015-05-15 16:07:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142643004/1
5 years, 7 months ago (2015-05-15 16:07:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 16:08:37 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 16:09:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6bfe1b5612e270f8882099e486ad3975fd5b80fb
Cr-Commit-Position: refs/heads/master@{#330102}

Powered by Google App Engine
This is Rietveld 408576698