Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1142603002: Fix blink_perf.canvas failure on chromium.perf (Closed)

Created:
5 years, 7 months ago by dshwang
Modified:
5 years, 7 months ago
CC:
blink-reviews, bajones
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix blink_perf.canvas failure on chromium.perf Some platform don't support "experimental-webgl" for Canvas.getContext API anymore. Use "webgl". BUG=488059, 455796 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M PerformanceTests/Canvas/draw-dynamic-webgl-to-hw-accelerated-canvas-2d.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Canvas/draw-static-webgl-to-hw-accelerated-canvas-2d.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Canvas/upload-canvas-2d-to-texture.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Canvas/upload-video-to-sub-texture.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Canvas/upload-video-to-texture.html View 1 chunk +1 line, -1 line 0 comments Download
M PerformanceTests/Canvas/upload-webgl-to-texture.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dshwang
kbr or other owners, could you review it urgently? now perf bots fails for 1.5 ...
5 years, 7 months ago (2015-05-15 08:34:32 UTC) #2
Sami
Thank you, lgtm.
5 years, 7 months ago (2015-05-15 09:48:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142603002/1
5 years, 7 months ago (2015-05-15 09:48:49 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195401
5 years, 7 months ago (2015-05-15 09:51:46 UTC) #7
Ken Russell (switch to Gerrit)
That's surprising. None of the code for accepting the "experimental-webgl" context type has been removed.
5 years, 7 months ago (2015-05-15 21:02:56 UTC) #8
Ken Russell (switch to Gerrit)
On 2015/05/15 21:02:56, Ken Russell wrote: > That's surprising. None of the code for accepting ...
5 years, 7 months ago (2015-05-15 21:04:32 UTC) #9
Sami
5 years, 7 months ago (2015-05-18 10:44:00 UTC) #10
Message was sent while issue was closed.
On 2015/05/15 21:04:32, Ken Russell wrote:
> On 2015/05/15 21:02:56, Ken Russell wrote:
> > That's surprising. None of the code for accepting the "experimental-webgl"
> > context type has been removed.
> 
> I think it's more likely that the test is running on a bot that doesn't have a
> real GPU. We've encountered this problem before with the
> smoothness.tough_webgl_cases benchmark. Code may be needed to avoid running
> these tests on bots that don't have WebGL support.

Ah, right, sorry I didn't notice this during the review. Arguably using webgl
instead of experimental-webgl is still the right thing to do here.

Let me comment on the bug.

Powered by Google App Engine
This is Rietveld 408576698