Generalize volume configuration over all volumes.

Generalize volume configuration over all volumes.

Since all volumes can be now configurable, make the method generic, instead of
limiting to FSP API only.

NOPRESUBMIT=true
TEST=Tested manually on configurable and non-configurable volumes.
BUG=474146
Committed: https://crrev.com/663f86d00dfc0ef90e8b841a7bd497301d8a2e98
Cr-Commit-Position: refs/heads/master@{#330285}

[mtomasz, 2015-05-15 03:49:15]

mtomasz@chromium.org changed reviewers:
+ yawano@chromium.org

[mtomasz, 2015-05-15 03:49:26]

@yawano: PTAL. Thanks.

[yawano, 2015-05-15 04:47:21]

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1376:
fileManager.volumeManager.configure(assert(volumeInfo));
very small optional nit: do you need assert() here even if it's under the
if-condition?

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
(right):

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js:333:
this.pendingTasks_.push(this.unmount.bind(this, volumeInfo));
this.unmount -> this.configure.

[mtomasz, 2015-05-15 06:26:12]

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/file_manager_commands.js
(right):

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/file_manager_commands.js:1376:
fileManager.volumeManager.configure(assert(volumeInfo));
On 2015/05/15 04:47:21, yawano wrote:
> very small optional nit: do you need assert() here even if it's under the
> if-condition?

Done.

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
(right):

https://codereview.chromium.org/1142593002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js:333:
this.pendingTasks_.push(this.unmount.bind(this, volumeInfo));
On 2015/05/15 04:47:21, yawano wrote:
> this.unmount -> this.configure.

Done.

[yawano, 2015-05-15 06:38:15]

lgtm. Thanks!

[mtomasz, 2015-05-15 12:09:18]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-05-15 12:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/1142593002/#ps40001
(title: "Fixed if.")

[mtomasz, 2015-05-15 12:09:24]

The CQ bit was unchecked by mtomasz@chromium.org

[mtomasz, 2015-05-15 12:09:50]

mtomasz@chromium.org changed reviewers:
+ fukino@chromium.org, isherman@chromium.org

[mtomasz, 2015-05-15 12:10:30]

@isherman: PTAL at histograms.
@fukino: PTAL at externs.

If lgtm, then please send to CQ, so hopefully we get it in before the branchcut.
Thanks.

[fukino, 2015-05-15 13:06:36]

externs lgtm.

[Ilya Sherman, 2015-05-15 17:25:26]

histograms.xml LGTM, thanks.

[Ilya Sherman, 2015-05-15 17:25:32]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2015-05-15 17:26:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142593002/40001

[commit-bot: I haz the power, 2015-05-15 17:35:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 17:35:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2015-05-16 05:19:30]

The CQ bit was checked by mtomasz@chromium.org

[mtomasz, 2015-05-16 05:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, fukino@chromium.org, yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/1142593002/#ps60001
(title: "Fixed the configure test.")

[commit-bot: I haz the power, 2015-05-16 05:19:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142593002/60001

[commit-bot: I haz the power, 2015-05-16 05:26:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-16 05:26:39]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mtomasz, 2015-05-16 09:48:32]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2015-05-16 09:48:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142593002/60001

[commit-bot: I haz the power, 2015-05-16 09:49:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-18 11:31:46]

Patchset 4 (id:??) landed as
https://crrev.com/663f86d00dfc0ef90e8b841a7bd497301d8a2e98
Cr-Commit-Position: refs/heads/master@{#330285}