ui/file_manager/file_manager/foreground/js/file_manager_commands.js - Issue 1142593002: Generalize volume configuration over all volumes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

Issue 1142593002: Generalize volume configuration over all volumes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the configure test. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/background/js/volume_manager.js ('k') | ui/file_manager/file_manager/foreground/js/providers_model.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/file_manager_commands.js

diff --git a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

index 674d53c6151ebea8a5d75a87d91a7e1114f1e73d..a57a79b0a62303c20b4a97f64aff814bf48df1a2 100644

--- a/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

+++ b/ui/file_manager/file_manager/foreground/js/file_manager_commands.js

@@ -1375,10 +1375,8 @@ CommandHandler.COMMANDS_['configure'] = (function() {

execute: function(event, fileManager) {

var volumeInfo = this.getCommandVolumeInfo_(event, fileManager);

- if (volumeInfo && volumeInfo.configurable) {

- fileManager.providersModel.requestConfigure(

- assert(volumeInfo.extensionId));

- }

+ if (volumeInfo && volumeInfo.configurable)

+ fileManager.volumeManager.configure(volumeInfo);

/**