Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1142523003: Add scheib to content/shell/OWNERS for bluetooth files. (Closed)

Created:
5 years, 7 months ago by scheib
Modified:
5 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scheib to content/shell/OWNERS for bluetooth files. This enables ownership of content shell support for testing Web Bluetooth. An example of early support being added in https://codereview.chromium.org/1132943002 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h/cc BUG=420275 Committed: https://crrev.com/128c707035cb40b0b0773ba4c13d9d3e34b41c27 Cr-Commit-Position: refs/heads/master@{#329957}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/shell/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
scheib
5 years, 7 months ago (2015-05-14 17:45:23 UTC) #2
pfeldman
lgtm
5 years, 7 months ago (2015-05-14 22:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142523003/1
5 years, 7 months ago (2015-05-14 22:29:10 UTC) #5
jochen (gone - plz use gerrit)
Note that test files aren't supposed to go in the top level directory, and per ...
5 years, 7 months ago (2015-05-14 22:32:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 22:36:36 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/128c707035cb40b0b0773ba4c13d9d3e34b41c27 Cr-Commit-Position: refs/heads/master@{#329957}
5 years, 7 months ago (2015-05-14 22:38:16 UTC) #8
scheib
On 2015/05/14 22:32:13, jochen (traveling) wrote: > Note that test files aren't supposed to go ...
5 years, 7 months ago (2015-05-14 23:08:29 UTC) #9
scheib
5 years, 7 months ago (2015-05-14 23:19:32 UTC) #10
Message was sent while issue was closed.
On 2015/05/14 23:08:29, scheib wrote:
> On 2015/05/14 22:32:13, jochen (traveling) wrote:
> > Note that test files aren't supposed to go in the top level directory, and
per
> > file rules aren't recursive
> 
> I'll fix up in a follow up patch.

https://codereview.chromium.org/1128423004

Powered by Google App Engine
This is Rietveld 408576698