Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1128423004: Correct addition of scheib, move from content/shell/OWNERS to ./browser/layout_test/OWNERS (Closed)

Created:
5 years, 7 months ago by scheib
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@bt-content-owner-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct addition of scheib, move from content/shell/OWNERS to ./browser/layout_test/OWNERS This enables ownership of content shell support for testing Web Bluetooth. An example of early support being added in https://codereview.chromium.org/1132943002 content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h/cc This change corrects https://codereview.chromium.org/1142523003 which incorrectly used the per-file directive. per-file only applies to files in the same directory as the OWNERS file. BUG=420275 Committed: https://crrev.com/97d5002e1966dfef3c630ae8759ea9d12b7cbfea Cr-Commit-Position: refs/heads/master@{#329975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M content/shell/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
A + content/shell/browser/layout_test/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scheib
5 years, 7 months ago (2015-05-14 23:20:22 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-14 23:29:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1128423004/1
5 years, 7 months ago (2015-05-14 23:31:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 23:39:58 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 23:40:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97d5002e1966dfef3c630ae8759ea9d12b7cbfea
Cr-Commit-Position: refs/heads/master@{#329975}

Powered by Google App Engine
This is Rietveld 408576698