Issue 1142523002: MemoryCache::resourceForURL(): add argument validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142523002: MemoryCache::resourceForURL(): add argument validation. (Closed)

Created:
5 years, 7 months ago by sof

Modified:
5 years, 7 months ago

Reviewers:
Nate Chapin

CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

MemoryCache::resourceForURL(): add argument validation. If querying the cache for the resource mapping of an empty or invalid URLs, return no resource, mirror the behavior of getEntryForResource(). R=japhet BUG=431640 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195366

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -1 line)			Patch
A	LayoutTests/fast/dom/HTMLImageElement/image-srcset-invalid-url-no-crash.html	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/dom/HTMLImageElement/image-srcset-invalid-url-no-crash-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/fetch/MemoryCache.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/fetch/MemoryCacheTest.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

please take a look. This seems the preferable option, but you could argue that the ...

5 years, 7 months ago (2015-05-14 16:43:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142523002/1

5 years, 7 months ago (2015-05-14 16:55:48 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-14 17:52:20 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195366

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages