Source/core/fetch/MemoryCache.cpp - Issue 1142523002: MemoryCache::resourceForURL(): add argument validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/fetch/MemoryCache.cpp

Issue 1142523002: MemoryCache::resourceForURL(): add argument validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-srcset-invalid-url-no-crash-expected.txt ('k') | Source/core/fetch/MemoryCacheTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/fetch/MemoryCache.cpp

diff --git a/Source/core/fetch/MemoryCache.cpp b/Source/core/fetch/MemoryCache.cpp

index de20b23e3248e1959ff3b96724dfb37776080f96..a7a9e740a41668446d565a0d0cd89f2c37aef85b 100644

--- a/Source/core/fetch/MemoryCache.cpp

+++ b/Source/core/fetch/MemoryCache.cpp

@@ -209,6 +209,9 @@ Resource* MemoryCache::resourceForURL(const KURL& resourceURL)

Resource* MemoryCache::resourceForURL(const KURL& resourceURL, const String& cacheIdentifier)

{

ASSERT(WTF::isMainThread());

+ if (!resourceURL.isValid() || resourceURL.isNull())

+ return nullptr;

+ ASSERT(!cacheIdentifier.isNull());

ResourceMap* resources = m_resourceMaps.get(cacheIdentifier);

if (!resources)

return nullptr;