Issue 1142423005: [M44 Merge] Refine dual-GPU detection on Mac OS X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142423005: [M44 Merge] Refine dual-GPU detection on Mac OS X. (Closed)

Created:
5 years, 7 months ago by Ken Russell (switch to Gerrit)

Modified:
5 years, 7 months ago

Reviewers:
Zhenyao Mo, ccameron

CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

[M44 Merge] Refine dual-GPU detection on Mac OS X. Only consider the system to have dual GPUs if one is an Intel GPU and the other isn't. This avoids problems where recent Mac Pros which contain dual AMD GPUs are considered to be "dual-GPU". One symptom was a 300 ms scroll lag on these machines once idle for 10 seconds as described in https://codereview.chromium.org/1147653002/ . BUG=380026 Review URL: https://codereview.chromium.org/1144843005 Cr-Commit-Position: refs/heads/master@{#330471} (cherry picked from commit 521697f5d826185b5e7126466110e72f1da2a26f) R=zmo@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/eee602315dae13a72361675dbb3ad8fe12c204e9

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -9 lines)			Patch
M	content/browser/gpu/gpu_data_manager_impl_private.cc	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	ui/gl/gpu_switching_manager.h	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	ui/gl/gpu_switching_manager.cc	View	4 chunks	+15 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Ken Russell (switch to Gerrit)

5 years, 7 months ago (2015-05-20 23:59:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eee602315dae13a72361675dbb3ad8fe12c204e9 (presubmit successful).