Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1144843005: Refine dual-GPU detection on Mac OS X. (Closed)

Created:
5 years, 7 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Zhenyao Mo, ccameron
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refine dual-GPU detection on Mac OS X. Only consider the system to have dual GPUs if one is an Intel GPU and the other isn't. This avoids problems where recent Mac Pros which contain dual AMD GPUs are considered to be "dual-GPU". One symptom was a 300 ms scroll lag on these machines once idle for 10 seconds as described in https://codereview.chromium.org/1147653002/ . BUG=380026 Committed: https://crrev.com/521697f5d826185b5e7126466110e72f1da2a26f Cr-Commit-Position: refs/heads/master@{#330471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M content/browser/gpu/gpu_data_manager_impl_private.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M ui/gl/gpu_switching_manager.h View 2 chunks +5 lines, -3 lines 0 comments Download
M ui/gl/gpu_switching_manager.cc View 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Ken Russell (switch to Gerrit)
zmo, ccameron: please review. tapted: could you please test this CL on your Mac Pro? ...
5 years, 7 months ago (2015-05-19 01:02:59 UTC) #2
Zhenyao Mo
LGTM kbr confirmed that on Mac, there haven't been any AMD switchables with a low-end ...
5 years, 7 months ago (2015-05-19 01:09:17 UTC) #3
Ken Russell (switch to Gerrit)
On 2015/05/19 01:09:17, Zhenyao Mo wrote: > LGTM > > kbr confirmed that on Mac, ...
5 years, 7 months ago (2015-05-19 01:10:19 UTC) #4
tapted
On 2015/05/19 01:10:19, Ken Russell wrote: > On 2015/05/19 01:09:17, Zhenyao Mo wrote: > > ...
5 years, 7 months ago (2015-05-19 01:17:39 UTC) #5
Ken Russell (switch to Gerrit)
On 2015/05/19 01:17:39, tapted wrote: > On 2015/05/19 01:10:19, Ken Russell wrote: > > On ...
5 years, 7 months ago (2015-05-19 01:28:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144843005/1
5 years, 7 months ago (2015-05-19 01:29:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 03:43:47 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 03:45:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/521697f5d826185b5e7126466110e72f1da2a26f
Cr-Commit-Position: refs/heads/master@{#330471}

Powered by Google App Engine
This is Rietveld 408576698