Make TableClassifierTest independent of browser window dimention

Make TableClassifierTest independent of browser window dimention

Test:
Change the xvfb resolution to 10x1000 and 1000x10 to trigger the failures
before this CL.

R=cjhopman@chromium.org, kuan@chromium.org

Committed: bf64df95d67848d6cfd5a15523a27de7bb020b34

[wychen, 2015-05-27 16:25:27]

wychen@chromium.org changed reviewers:
+ cjhopman@chromium.org, kuan@chromium.org

[wychen, 2015-05-27 16:25:28]

PTAL

[cjhopman, 2015-05-28 21:30:03]

https://codereview.chromium.org/1142323005/diff/1/javatests/org/chromium/dist...
File javatests/org/chromium/distiller/TableClassifierTest.java (right):

https://codereview.chromium.org/1142323005/diff/1/javatests/org/chromium/dist...
javatests/org/chromium/distiller/TableClassifierTest.java:17:
mRoot.getStyle().setProperty("width", "800px");
How about just doing this in DomDistillerJsTestCase?

[wychen, 2015-05-29 06:43:10]

https://codereview.chromium.org/1142323005/diff/1/javatests/org/chromium/dist...
File javatests/org/chromium/distiller/TableClassifierTest.java (right):

https://codereview.chromium.org/1142323005/diff/1/javatests/org/chromium/dist...
javatests/org/chromium/distiller/TableClassifierTest.java:17:
mRoot.getStyle().setProperty("width", "800px");
On 2015/05/28 21:30:02, cjhopman wrote:
> How about just doing this in DomDistillerJsTestCase?

That's what I originally did. I thought it might be better to confine that fixed
width to this test specifically since this is the only layout-dependent test.

We might do other layout-dependent tests later, like image detection, so I've
reverted to doing this in DomDistillerJsTestCase.

[wychen, 2015-06-01 20:12:57]

wychen@chromium.org changed reviewers:
+ mdjones@chromium.org

[wychen, 2015-06-01 20:12:58]

+mdjones for impact of future image detection and testing.

[mdjones, 2015-06-02 20:52:48]

On 2015/06/01 20:12:58, wychen wrote:
> +mdjones for impact of future image detection and testing.

Currently the image tests have a static width and height (in px) set for any of
the images. Unless we start using percentages for image dimensions the tests
should remain unaffected.

[cjhopman, 2015-06-05 00:37:13]

lgtm

[kuan, 2015-06-05 00:40:05]

thx for fixing the table tests!  lgtm.

[wychen, 2015-06-05 23:17:11]

Committed patchset #2 (id:20001) manually as
bf64df95d67848d6cfd5a15523a27de7bb020b34 (presubmit successful).