Make TableClassifierTest independent of browser window dimention

javatests/org/chromium/distiller/TableClassifierTest.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.distiller;
 
 import com.google.gwt.dom.client.Document;
 import com.google.gwt.dom.client.Element;
 import com.google.gwt.dom.client.NodeList;
 import com.google.gwt.dom.client.TableElement;
 
-public class TableClassifierTest extends DomDistillerJsTestCase {
+class FixedWidthJsTestCase extends DomDistillerJsTestCase {
+    @Override
+    public void setUp() throws Exception {
+        super.setUp();
+         // With this, the width of chrome window won't affect the layout.
+        mRoot.getStyle().setProperty("width", "800px");

[cjhopman, 2015/05/28 21:30:02]

How about just doing this in DomDistillerJsTestCase?

[wychen, 2015/05/29 06:43:10]

That's what I originally did. I thought it might be better to confine that fixed
width to this test specifically since this is the only layout-dependent test.

We might do other layout-dependent tests later, like image detection, so I've
reverted to doing this in DomDistillerJsTestCase.

+   }
+}
+
+public class TableClassifierTest extends FixedWidthJsTestCase {
+    public void testDocumentWidth() {
+        assertEquals(800, mRoot.getOffsetWidth());
+        assertEquals("800px", DomUtil.getComputedStyle(mRoot).getProperty("width"));
+    }
+
     public void testInputElement() {
         Element input = Document.get().createTextInputElement();
         mBody.appendChild(input);
         TableElement table = createDefaultTableWithTH();
         input.appendChild(table);
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.INSIDE_EDITABLE_AREA, TableClassifier.sReason);
     }
 
     public void testContentEditableAttribute() {
@@ skipping 264 matching lines @@
         abbr.setInnerHTML("HTML");
         td.appendChild(abbr);
         Element tr = getFirstElement(table, "TR");
         tr.appendChild(td);
         assertEquals(TableClassifier.Type.DATA, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.ONLY_HAS_ABBR, TableClassifier.sReason);
     }
 
     public void testWideTable() {
         TableElement table = createDefaultTableWithNoTH();
-        Element root = Document.get().getDocumentElement();
-        int width = (int) ((0.95 * root.getOffsetWidth()) + 1.0);
+        int rootWidth = mRoot.getOffsetWidth();
+        int width = (int) ((0.95 * rootWidth) + 1.0);
         table.setAttribute("style", "width:" + width + "px");
-        NodeList<Element> bodies = root.getElementsByTagName("BODY");
-        assertTrue(bodies.getLength() > 0);
-        bodies.getItem(0).appendChild(table);
+        assertEquals(rootWidth, mRoot.getOffsetWidth());
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.MORE_95_PERCENT_DOC_WIDTH, TableClassifier.sReason);
 
         // Test same wide table with viewport meta.
-        NodeList<Element> heads = root.getElementsByTagName("HEAD");
-        assertTrue(heads.getLength() > 0);
         Element meta = TestUtil.createMetaName("viewport", "width=device-width");
-        heads.getItem(0).appendChild(meta);
+        mHead.appendChild(meta);
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.LESS_EQ_10_CELLS, TableClassifier.sReason);
         meta.removeFromParent();
     }
 
     public void testSummaryAttribute() {
         TableElement table = createDefaultTableWithNoTH();
         table.setAttribute("summary", "Testing summary attribute");
         assertEquals(TableClassifier.Type.DATA, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.SUMMARY, TableClassifier.sReason);
@@ skipping 125 matching lines @@
 
     public void testAppletElement() {
         TableElement table = createBigDefaultTableWithNoTH();
         Element embed = Document.get().createElement("APPLET");
         getFirstElement(table, "TD").appendChild(embed);
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.EMBED_OBJECT_APPLET_IFRAME, TableClassifier.sReason);
     }
 
     public void testIframeElement() {
+        int rootWidth = mRoot.getOffsetWidth();
         TableElement table = createBigDefaultTableWithNoTH();
         Element embed = Document.get().createElement("IFRAME");
         getFirstElement(table, "TD").appendChild(embed);
+        assertEquals(rootWidth, mRoot.getOffsetWidth());
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.EMBED_OBJECT_APPLET_IFRAME, TableClassifier.sReason);
     }
 
     public void testTallTable() {
         TableElement table = createBigDefaultTableWithNoTH();
-        Element root = Document.get().getDocumentElement();
-        int height = (int) ((0.90 * root.getOffsetHeight()) + 1.0);
+        // With min-height, the height of mRoot remains the same after resizing the table.
+        mRoot.getStyle().setProperty("min-height", "200px");
+        int rootHeight = mRoot.getOffsetHeight();
+        int height = (int) ((0.90 * rootHeight) + 1.0);
         table.setAttribute("style", "height:" + height + "px");
-        NodeList<Element> bodies = root.getElementsByTagName("BODY");
-        assertTrue(bodies.getLength() > 0);
-        bodies.getItem(0).appendChild(table);
+        assertEquals(height, table.getOffsetHeight());
+        assertEquals(rootHeight, mRoot.getOffsetHeight());
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.MORE_90_PERCENT_DOC_HEIGHT, TableClassifier.sReason);
     }
 
     private TableElement createTable(String html) {
         TableElement table = Document.get().createTableElement();
         table.setInnerHTML(html);
         mBody.appendChild(table);
         return table;
     }
 
     private TableElement createDefaultTableWithTH() {
         String tableStr = "<tbody>" +
                               "<tr>" +
                                   "<th>heading1</th>" +
                                   "<th>heading2</th>" +
                               "</tr>" +
                               "<tr>" +
                                   "<td>row1col1</td>" +
                                   "<td>row1col2</td>" +
                               "</tr>" +
                               "<tr>" +
                                   "<td>row2col1</td>" +
                                   "<td>row2col2</td>" +
                               "</tr>" +
                           "</tbody>";
         TableElement table = createTable(tableStr);
+        mBody.appendChild(table);
         assertEquals(TableClassifier.Type.DATA, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.CAPTION_THEAD_TFOOT_COLGROUP_COL_TH,
                      TableClassifier.sReason);
-        mBody.appendChild(table);
         return table;
     }
 
     private TableElement createDefaultTableWithNoTH() {
         String tableStr = "<tbody>" +
                               "<tr>" +
                                   "<td>row1col1</td>" +
                                   "<td>row1col2</td>" +
                               "</tr>" +
                               "<tr>" +
                                   "<td>row2col1</td>" +
                                   "<td>row2col2</td>" +
                               "</tr>" +
                           "</tbody>";
         TableElement table = createTable(tableStr);
+        mBody.appendChild(table);
         assertEquals(TableClassifier.Type.LAYOUT, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.LESS_EQ_10_CELLS, TableClassifier.sReason);
-        mBody.appendChild(table);
         return table;
     }
 
     private TableElement createBigDefaultTableWithNoTH() {
         String tableStr = "<tbody>" +
                               "<tr>" +
                                   "<td>row1col1</td>" +
                                   "<td>row1col2</td>" +
                                   "<td>row1col3</td>" +
                                   "<td>row1col4</td>" +
                               "</tr>" +
                               "<tr>" +
                                   "<td>row2col1</td>" +
                                   "<td>row2col2</td>" +
                                   "<td>row2col3</td>" +
                                   "<td>row2col4</td>" +
                               "</tr>" +
                               "<tr>" +
                                   "<td>row3col1</td>" +
                                   "<td>row3col2</td>" +
                                   "<td>row3col3</td>" +
                                   "<td>row3col4</td>" +
                               "</tr>" +
                           "</tbody>";
         TableElement table = createTable(tableStr);
+        mBody.appendChild(table);
         assertEquals(TableClassifier.Type.DATA, TableClassifier.table(table));
         assertEquals(TableClassifier.Reason.DEFAULT, TableClassifier.sReason);
-        mBody.appendChild(table);
         return table;
     }
 
     private void setRoleForFirstElement(Element table, String tagname, String role) {
         setAttributeForFirstElement(table, tagname, "role", role);
     }
 
     private void setAttributeForFirstElement(Element table, String tagname, String attrName,
             String attrValue) {
         getFirstElement(table, tagname).setAttribute(attrName, attrValue);
@@ skipping 31 matching lines @@
 
     private TableElement createNestedTable(String nestedTableStr, Element parentTable) {
         TableElement nestedTable = createTable(nestedTableStr);
         // Insert nested table into 1st row of |parentTable|.
         NodeList<Element> rows = parentTable.getElementsByTagName("TR");
         assertEquals(2, rows.getLength());
         rows.getItem(0).appendChild(nestedTable);
         return nestedTable;
    }
 }